Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

update kvdb & co #12312

Merged
merged 10 commits into from
Oct 5, 2022
Merged

update kvdb & co #12312

merged 10 commits into from
Oct 5, 2022

Conversation

ordian
Copy link
Member

@ordian ordian commented Sep 20, 2022 •
edited
Loading

polkadot companion: paritytech/polkadot#6111

Major updates:

  • rocksdb 6.28.2 -> 7.4.4
  • jemalloc 5.2.1 -> 5.3.0
  • uint and fixed-hash (e.g. U256 and H256 types) can now be deserialized from hex string without 0x prefix
  • some breaking changes to kvdb API (mostly for the companion)

@ordian ordian added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. E3-dependencies labels Sep 20, 2022
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Sep 20, 2022
@ordian ordian added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit label Sep 20, 2022
@ordian
Copy link
Member Author

ordian commented Sep 20, 2022 •
edited
Loading 

thread 'tests::should_parse_extrinsic_address' panicked at 'assertion failed: `(left == right)`
  left: `Ok(Bytes([18, 52]))`,
 right: `Err("Extrinsic index missing: example \"5:0\"")`', bin/node/inspect/src/lib.rs:299:9

doesn't seem to be related to the PR

EDIT: on the second thought it does...

@ordian
Copy link
Member Author

ordian commented Sep 20, 2022

impl-serde 0.3.2 added support for deserializing without 0x prefix: paritytech/parity-common#598. This broke the test. Should I change the test? Or this assumption is baked in other places?

@bkchr
Copy link
Member

bkchr commented Sep 20, 2022

impl-serde 0.3.2 added support for deserializing without 0x prefix: paritytech/parity-common#598. This broke the test. Should I change the test? Or this assumption is baked in other places?

Looks reasonable to support without leading 0x as you have done it.

@ordian
Merge branch 'master' into ao-update-kvdb-and-co
45adc12 
* master:
  [Fix] parameter_types! dead code errors (#12340)
  [Feature] Sequential migration execution for try-runtime (#12319)
  bench: Use `_` instead  of `::` in auto-generated file names (#12332)
  Fast Unstake Pallet (#12129)
  Rename anonymous to pure proxy (#12283)
  Migrate remaining old decl_* macros to the new pallet attribute macros (#12271)
  pallet-utility: Disallow none origin (#12321)
  Make automatic storage deposits resistant against changing deposit prices (#12083)
  Format templates and fix `--steps` default value (#12286)
  Bump `wasmtime` to 1.0.0 (#12317)
  Introduce 'intermediate_insert' method to hide implementation details (#12215)
  Bound staking storage items (#12230)
  Use `array-bytes` for All Array/Bytes/Hex Operations (#12190)
  BREAKING: Rename Origin (#12258)
  Use temporary db for benchmarking (#12254)
  rpc: Implement `chainSpec` RPC API (#12261)
  Import target block body during warp sync (#12300)
  Proper naming wrt expectations (#12311)
  [ci] Revert cancel-pipeline job (#12309)
cheme
cheme approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@cheme cheme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (should have review 14 days ago but did miss it).

@ordian
Merge branch 'master' into ao-update-kvdb-and-co
bd29c35 
* master: (42 commits)
  Adapt `pallet-contracts` to WeightV2 (#12421)
  Improved election pallet testing (#12327)
  Bump prost to 0.11+ (#12419)
  Use saturating add for alliance::disband witness data (#12418)
  [Fix] Rename VoterBagsList -> VoterList to match pdot (#12416)
  client/beefy: small code improvements (#12414)
  BEEFY: Simplify hashing for pallet-beefy-mmr (#12393)
  Add @koute to `docs/CODEOWNERS` and update stale paths (#12408)
  docs/CODEOWNERS: add @acatangiu as MMR owner (#12406)
  Remove unnecessary Clone trait bounds on CountedStorageMap (#12402)
  Fix `Weight::is_zero` (#12396)
  Beefy on-demand justifications as a custom RequestResponse protocol (#12124)
  Remove contracts RPCs (#12358)
  pallet-mmr: generate historical proofs (#12324)
  unsafe_pruning flag removed (#12385)
  Carry over where clauses defined in Config to Call and Hook (#12388)
  Properly set the max proof size weight on defaults and tests (#12383)
  BEEFY: impl TypeInfo for SignedCommitment (#12382)
  bounding staking: `BoundedElectionProvider` trait (#12362)
  New Pallet: Root offences (#11943)
  ...
@ordian ordian requested a review from koute as a code owner October 5, 2022 13:38
@ordian ordian marked this pull request as draft October 5, 2022 13:40
@ordian ordian mentioned this pull request Oct 5, 2022
Merged
@ordian ordian marked this pull request as ready for review October 5, 2022 17:34
@ordian
Merge branch 'master' into ao-update-kvdb-and-co
d31a98d 
* master:
  Implement `Clone` and `Default` for `Config` (#12397)
  Don't send back empty proofs if light request fails (#12372)
  MMR: impl `TypeInfo` for some structures (#12423)
@ordian
Copy link
Member Author

ordian commented Oct 5, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit fc67cbb into master Oct 5, 2022
@paritytech-processbot paritytech-processbot bot deleted the ao-update-kvdb-and-co branch October 5, 2022 21:07
@github-actions github-actions bot mentioned this pull request Nov 10, 2022
Closed
@github-actions github-actions bot mentioned this pull request Nov 23, 2022
Closed
@aurexav aurexav mentioned this pull request Jan 10, 2023
Closed
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@ordian @ark0f
update kvdb & co (paritytech#12312)
546caec 
* upgrade kvdb & co

* remove patch

* update Cargo.lock

* upgrade impl-serde

* fix parsing test

* actually fix it

* FFS
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

@cheme cheme cheme approved these changes

@koute koute Awaiting requested review from koute koute is a code owner

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
SDK Node
Status: done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ordian @bkchr @cheme