Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix Origins Used in Runtime Benchmarks #12037

Merged
merged 8 commits into from
Aug 16, 2022
Merged

Fix Origins Used in Runtime Benchmarks #12037

merged 8 commits into from
Aug 16, 2022

Conversation

shawntabrizi
Copy link
Member

Some benchmarks assume Root origin, instead of calling the appropriate successful_origin.

This fixes that.

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Aug 16, 2022
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
The job name - test-linux-stable
The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1747370

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
The job name - test-linux-stable
The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1747371

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
The job name - test-linux-stable
The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1747372

@shawntabrizi shawntabrizi added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Aug 16, 2022
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
The job name - cargo-check-benches
The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1747410

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
The job name - cargo-check-benches
The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1747446

@kianenigma kianenigma added B3-apinoteworthy and removed B0-silent Changes should not be mentioned in any release notes labels Aug 16, 2022
@shawntabrizi
Copy link
Member Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 97ae6be into master Aug 16, 2022
@paritytech-processbot paritytech-processbot bot deleted the shawntabrizi-fix-benchmark-origin branch August 16, 2022 10:36
@librelois librelois mentioned this pull request Sep 15, 2022
Closed
2 tasks
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@shawntabrizi @ark0f
Fix Origins Used in Runtime Benchmarks (paritytech#12037)
959259e 
* fix identity benchmark origin

* fix benchmarking macro

* bounties

* democracy

* scheduler

* tips and treasury

* unused

* dunno, this is causing issues
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@kianenigma kianenigma kianenigma approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
Benchmarking and Weights
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shawntabrizi @paritytech-cicd-pr @kianenigma @ggwpez