Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Improve wasmtime error reporting #11856

Merged

Conversation

koute
Copy link
Contributor

@koute koute commented Jul 18, 2022

Fixes #11848

wasmtime uses anyhow for its errors which are not fully printed out by default when stringified using Display; instead we have to use {:#} to make it display the full error.

@koute koute added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jul 18, 2022
@koute koute requested review from pepyakin and a team July 18, 2022 06:26
Copy link
Contributor

@skunert skunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@koute
Copy link
Contributor Author

koute commented Jul 18, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 8016da9 into paritytech:master Jul 18, 2022
DaviRain-Su pushed a commit to octopus-network/substrate that referenced this pull request Aug 23, 2022
* Improve `wasmtime` error reporting

* cargo fmt
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* Improve `wasmtime` error reporting

* cargo fmt
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

Do not swallow the errors from wasmtime
3 participants