-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[contracts] Fix *storage_per_kb
benchmarks
#11756
Conversation
…ware (to make tests pass before re-run benchmarks)
/cmd queue -c bench-bot $ pallet dev pallet_contracts |
@joao-paulo-parity https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1664124 was started for your command Comment |
@joao-paulo-parity Command |
Last job timed out due to a problem in the bot, but it should be fixed now. Let's try again: /cmd queue -c bench-bot $ pallet dev pallet_contracts |
@joao-paulo-parity https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1664368 was started for your command Comment |
@joao-paulo-parity Command |
This didn't really removed the reads per |
@athei re #11756 (comment), as Oliver noticed in #11756 (comment) the benchmarks were using the wrong machine by accident, but it seems like this was fixed in https://github.com/paritytech/ci_cd/issues/518#issuecomment-1184634791. Sorry about that! Let's try it again: /cmd queue -c bench-bot $ pallet dev pallet_contracts |
@joao-paulo-parity https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1677829 was started for your command Comment |
@joao-paulo-parity Command |
/cmd queue -c bench-bot $ pallet dev pallet_contracts |
@athei https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1700666 was started for your command Comment |
@athei Command |
Ok this also didn't work. We will just live with the slight overestimation. |
As @athei noticed in #11501,
*storage_per_kb
benchmarks include a read/write component pern
, which is not right.By this PR, storage keys generated in those benchmarks are whitelisted in DB in order to fix that.