This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Make sure the commit hash is always of the same length in impl_version
#11404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koute
added
A0-please_review
davxy
approved these changes
May 12, 2022
bkchr
approved these changes
May 12, 2022
bkchr
reviewed
May 12, 2022
skunert
approved these changes
May 12, 2022
|
bot merge |
godcodehunter
pushed a commit
to sensoriumxr/substrate
that referenced
this pull request
Jun 22, 2022
…on` (paritytech#11404) * Make sure the commit hash is always of the same length in `impl_version` * Add a comment regarding the length of the commit hash
3 tasks
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this pull request
Aug 23, 2022
…on` (paritytech#11404) * Make sure the commit hash is always of the same length in `impl_version` * Add a comment regarding the length of the commit hash
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
…on` (paritytech#11404) * Make sure the commit hash is always of the same length in `impl_version` * Add a comment regarding the length of the commit hash
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed this little issue in our telemetry:
The commit hashes appended to the version strings are of different lengths, even for exactly the same version.
As it turns out we use
git rev-parse --short HEADto grab those, and, to quote the git manpage (emphasis mine):So it just picks either whatever is the default (which can vary depending on the exact installed
gitversion) or whatever was configured in~/.gitconfig.So this PR makes those hashes always at least 11 characters long. (Since that's currently the longest one in our telemetry.)