This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Consensus message buffering and more #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkpar
added
the
A3-in_progress
arkpar
changed the title
arkpar
added
A0-please_review
rphmeier
reviewed
Apr 6, 2018
| @@ -12,7 +12,7 @@ log = "0.3" | |||
| hex-literal = "0.1" | |||
| triehash = "0.1" | |||
| ed25519 = { path = "../../substrate/ed25519" } | |||
| app_dirs = "1.2.1" | |||
There was a problem hiding this comment.
Cargo.lock is already pointing to the latest version.
rphmeier
reviewed
Apr 6, 2018
| match self.network_stream.poll() { | ||
| Err(_) => Err(bft::InputStreamConcluded.into()), | ||
| Ok(Async::NotReady) => Ok(Async::NotReady), | ||
| Ok(Async::Ready(None)) => Ok(Async::NotReady), // the input stream for agreements is never meant to logically end. |
There was a problem hiding this comment.
this is kind of a hack which depends on the fact that an actual long-running agreement has the underlying network stream live for the whole time. I couldn't think of a better way around it though.
rphmeier
approved these changes
Apr 6, 2018
gavofyork
approved these changes
Apr 6, 2018
lamafab
pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
* Add claims. * Failing build * Updatee to latest substrate, fix tests * Remove unneeded * Introduce tests with real work sig * Use right 64 bytes of pubkey to get eth addr * Fix for eth sig * Fix build * Fix wasm * Use new externs for eth crypto. * Bump spec version * New runtime
JoshOrndorff
pushed a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Apr 21, 2021
* Update frontier pin * Add version tests
liuchengxu
pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
* support ChannelRelationship * move runtime balance
liuchengxu
pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
* add xassets init in genesis * fix polkadot.js doc
liuchengxu
pushed a commit
to autonomys/substrate
that referenced
this pull request
Jun 3, 2022
Farmer lib phase3a - Plotting
helin6
pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.