Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

serde::{Serialize, Deserialize} for BoundedVec #11314

Merged
merged 5 commits into from
May 16, 2022

Conversation

shabanovd
Copy link
Contributor

@shabanovd shabanovd commented Apr 28, 2022

Implement serde's serialize and deserialize with boundary check

Issue #11315

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Apr 28, 2022

User @shabanovd, please sign the CLA here.

@shabanovd shabanovd marked this pull request as ready for review April 29, 2022 14:16
@shabanovd shabanovd requested a review from bkchr May 4, 2022 12:09
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add it to the other bounded_xxx types as well? should be fairly similar to do so.

@shabanovd
Copy link
Contributor Author

Should add it to the other bounded_xxx types as well? should be fairly similar to do so.

@kianenigma do you mean WeakBoundedVec, BoundedSlice, BoundedBTreeMap and BoundedBTreeSet? or just BoundedBTreeMap and BoundedBTreeSet?

@shabanovd shabanovd requested a review from KiChjang May 5, 2022 16:45
@shabanovd shabanovd requested a review from kianenigma May 9, 2022 05:55
@shabanovd
Copy link
Contributor Author

@bkchr wander, what is next step?

@bkchr bkchr added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit A0-please_review Pull request needs code review. labels May 16, 2022
frame/support/src/storage/bounded_vec.rs Outdated Show resolved Hide resolved
frame/support/src/storage/bounded_vec.rs Outdated Show resolved Hide resolved
frame/support/src/storage/bounded_vec.rs Outdated Show resolved Hide resolved
@bkchr
Copy link
Member

bkchr commented May 16, 2022

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@bkchr
Copy link
Member

bkchr commented May 16, 2022

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Head SHA changed from cc2cd13 to 39c2e79

@bkchr bkchr merged commit 4fd77a9 into paritytech:master May 16, 2022
@shabanovd
Copy link
Contributor Author

@bkchr thanks!

@shabanovd shabanovd deleted the serde_for_bounded_vec branch May 16, 2022 11:38
godcodehunter pushed a commit to sensoriumxr/substrate that referenced this pull request Jun 22, 2022
* serde::{Serialize, Deserialize} for BoundedVec

* Apply suggestions from code review

* FMT

* 🤦

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Co-authored-by: Bastian Köcher <info@kchr.de>
DaviRain-Su pushed a commit to octopus-network/substrate that referenced this pull request Aug 23, 2022
* serde::{Serialize, Deserialize} for BoundedVec

* Apply suggestions from code review

* FMT

* 🤦

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Co-authored-by: Bastian Köcher <info@kchr.de>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* serde::{Serialize, Deserialize} for BoundedVec

* Apply suggestions from code review

* FMT

* 🤦

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Co-authored-by: Bastian Köcher <info@kchr.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants