This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
serde::{Serialize, Deserialize} for BoundedVec #11314
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User @shabanovd, please sign the CLA here. |
bkchr
reviewed
Apr 29, 2022
kianenigma
reviewed
May 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should add it to the other bounded_xxx types as well? should be fairly similar to do so.
@kianenigma do you mean |
KiChjang
reviewed
May 5, 2022
KiChjang
reviewed
May 7, 2022
KiChjang
reviewed
May 7, 2022
KiChjang
approved these changes
May 9, 2022
c69cd5b
to
05b6a2f
Compare
@bkchr wander, what is next step? |
bkchr
approved these changes
May 16, 2022
bkchr
reviewed
May 16, 2022
bot merge |
Waiting for commit status. |
bot merge |
Waiting for commit status. |
@bkchr thanks! |
godcodehunter
pushed a commit
to sensoriumxr/substrate
that referenced
this pull request
Jun 22, 2022
* serde::{Serialize, Deserialize} for BoundedVec * Apply suggestions from code review * FMT * 🤦 Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: Bastian Köcher <info@kchr.de>
3 tasks
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this pull request
Aug 23, 2022
* serde::{Serialize, Deserialize} for BoundedVec * Apply suggestions from code review * FMT * 🤦 Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: Bastian Köcher <info@kchr.de>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* serde::{Serialize, Deserialize} for BoundedVec * Apply suggestions from code review * FMT * 🤦 Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: Bastian Köcher <info@kchr.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement serde's serialize and deserialize with boundary check
Issue #11315