Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove not required DigestItem conversion #11165

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Remove not required DigestItem conversion #11165

merged 1 commit into from
Apr 4, 2022

Conversation

davxy
Copy link
Member

@davxy davxy commented Apr 4, 2022 •
edited
Loading

FRAME system deposit_log takes a DigestItem, i.e. exactly the type we are passing in

@davxy davxy requested a review from andresilva as a code owner April 4, 2022 13:47
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Apr 4, 2022
@davxy davxy requested a review from a team April 4, 2022 13:51
@davxy davxy added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Apr 4, 2022
wigy-opensource-developer
wigy-opensource-developer approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@wigy-opensource-developer wigy-opensource-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite surprising enum DigestItem is not dependent on the Config, but is under the sp_runtime::generic module. But this way no conversion is needed, indeed.

@bkchr
Copy link
Member

bkchr commented Apr 4, 2022

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 6f411cd into master Apr 4, 2022
@paritytech-processbot paritytech-processbot bot deleted the davxy-remove-not-required-conversion branch April 4, 2022 14:29
DaviRain-Su pushed a commit to octopus-network/substrate that referenced this pull request Aug 23, 2022
@davxy @DaviRain-Su
Remove not required DigestItem conversion (paritytech#11165)
1b79883
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@davxy @ark0f
Remove not required DigestItem conversion (paritytech#11165)
7554ed1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wigy-opensource-developer wigy-opensource-developer wigy-opensource-developer approved these changes

@bkchr bkchr bkchr approved these changes

@andresilva andresilva Awaiting requested review from andresilva

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davxy @bkchr @wigy-opensource-developer