Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Spellcheck HBS templates and add test #11119

Merged
merged 6 commits into from
Mar 29, 2022
Merged

Spellcheck HBS templates and add test #11119

merged 6 commits into from
Mar 29, 2022

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Mar 25, 2022

  • The Polkadot spellcheck and fmt CI rejected my filled out templates, this should fix it.
  • Test that benchmark-storage works with the --dev runtime

@ggwpez
Spellcheck HBS templates and fix vars
7314bd9 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Add test for benchmark-storage
cd2692f 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Fmt templates
75781f9 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Mar 25, 2022
@ggwpez
fmt
c5f6b29 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Merge remote-tracking branch 'origin/master' into oty-hbs-spellcheck
dd6b843
bkchr
bkchr approved these changes Mar 28, 2022
View reviewed changes
bin/node/cli/tests/benchmark_storage_works.rs Outdated Show resolved Hide resolved
@ggwpez @bkchr
Review fixes
7ef960e 
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
gilescope
gilescope approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@gilescope gilescope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ggwpez
Copy link
Member Author

ggwpez commented Mar 29, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 09073d3 into master Mar 29, 2022
@paritytech-processbot paritytech-processbot bot deleted the oty-hbs-spellcheck branch March 29, 2022 12:07
drahnr
drahnr reviewed Mar 29, 2022
View reviewed changes
utils/frame/benchmarking-cli/src/overhead/weights.hbs
{{/if}}
/// Calculated by multiplying the *{{params.weight.weight_metric}}* with `{{params.weight.weight_mul}}` and adding `{{params.weight.weight_add}}`.
///
/// Stats [ns]:
/// Stats [NS]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iiuc this is nanoseconds, correct? If so, we should add this as a whitelist item in the spellcheck.conf rather than adjusting the case.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Having some of these whitelisted would be nice 🙏

Copy link
Contributor

@drahnr drahnr Mar 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding something like https://github.com/paritytech/polkadot/blob/master/scripts/gitlab/spellcheck.toml with https://github.com/paritytech/polkadot/blob/master/scripts/gitlab/lingua.dic

drahnr
drahnr reviewed Mar 29, 2022
View reviewed changes
utils/frame/benchmarking-cli/src/overhead/weights.hbs
/// Min, Max: {{underscore stats.min}}, {{underscore stats.max}}
/// Average: {{underscore stats.avg}}
/// Median: {{underscore stats.median}}
/// StdDev: {{stats.stddev}}
/// Std-Dev: {{stats.stddev}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC

DaviRain-Su pushed a commit to octopus-network/substrate that referenced this pull request Aug 23, 2022
@ggwpez @bkchr @DaviRain-Su
Spellcheck HBS templates and add test (paritytech#11119)
146233c 
* Spellcheck HBS templates and fix vars

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Add test for benchmark-storage

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fmt templates

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* fmt

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Review fixes

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@ggwpez @bkchr @ark0f
Spellcheck HBS templates and add test (paritytech#11119)
449e3e7 
* Spellcheck HBS templates and fix vars

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Add test for benchmark-storage

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fmt templates

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* fmt

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Review fixes

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@drahnr drahnr drahnr left review comments

@gilescope gilescope gilescope approved these changes

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ggwpez @drahnr @gilescope @shawntabrizi @bkchr