This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Don't ban peers for small duplicate requests #11084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
approved these changes
Mar 21, 2022
bkchr
reviewed
Mar 21, 2022
bkchr
added
A0-please_review
arkpar
approved these changes
Mar 22, 2022
|
bot merge |
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* Don't ban peers for small duplicate requests * Address review comment
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* Don't ban peers for small duplicate requests * Address review comment
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* Don't ban peers for small duplicate requests * Address review comment
This was referenced May 15, 2022
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this pull request
Aug 23, 2022
* Don't ban peers for small duplicate requests * Address review comment
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Don't ban peers for small duplicate requests * Address review comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR permits duplicate block requests from peers if the request is "small", defined as when only the block header and justification are requested. A separate, milder reputation penalty is issued for those duplicates. This prevents peers from being banned for (e.g.) duplicate ancestor search requests, which can occur if a peer has disconnected and reconnected. This is one of the solutions discussed in #10794.
Should resolve #10794.