This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Dependency Injection Trait Locker for Uniques Pallet #11025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted downstream to enable locking of an asset. Use case defined in RMRK substrate pallet PR76
|
User @HashWarlock, please sign the CLA here. |
|
LGTM |
xlc
reviewed
Mar 14, 2022
This was referenced Mar 14, 2022
shawntabrizi
added
B7-runtimenoteworthy
C1-low
shawntabrizi
approved these changes
Mar 16, 2022
kianenigma
reviewed
Mar 23, 2022
kianenigma
approved these changes
Mar 23, 2022
|
Any other updates I need to make to ensure this gets merged? |
|
Looking at the checks, you need a polkadot companion. Otherwise good to go 👍 |
Would this be the companion you mean? paritytech/cumulus#1085 or I need to add additional one to the polkadot repo as well? |
|
Yes but you have to put it in the PR description (which I did for you now :) ) |
|
bot merge |
|
Error: pr-custom-review is not passing for paritytech/cumulus#1085 |
Thank you for the help. Do I need labels and approvals on the cumulus PR as well? |
|
We have to wait for the new review rules to approve the cumulus companion, sorry for the delay! |
|
bot merge |
|
Error: "Check reviews" status is not passing for paritytech/cumulus#1085 |
shawntabrizi
added
the
B0-silent
|
bot merge |
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Checks failed for cb4eeb2 |
|
bot rebase |
|
Rebasing |
|
bot merge |
godcodehunter
pushed a commit
to sensoriumxr/substrate
that referenced
this pull request
Jun 22, 2022
* Create a dependency injection trait named Locker that can be implemented downstream to enable locking of an asset. Use case defined in RMRK substrate pallet PR76 * Formatting * Change impl Locker function name to is_locked * Remove unused import * Add docstring header * Remove impl_locker file and add Locker trait to frame_support::traits * Expose Locker from frame_support::traits::misc * Formatting * Move to tokens folder * Move to tokens folder * Format and remove Locker from misc traits * Punctuation * Update frame/support/src/traits/tokens/misc.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> Co-authored-by: Giles Cope <gilescope@gmail.com>
10 tasks
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this pull request
Aug 23, 2022
* Create a dependency injection trait named Locker that can be implemented downstream to enable locking of an asset. Use case defined in RMRK substrate pallet PR76 * Formatting * Change impl Locker function name to is_locked * Remove unused import * Add docstring header * Remove impl_locker file and add Locker trait to frame_support::traits * Expose Locker from frame_support::traits::misc * Formatting * Move to tokens folder * Move to tokens folder * Format and remove Locker from misc traits * Punctuation * Update frame/support/src/traits/tokens/misc.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> Co-authored-by: Giles Cope <gilescope@gmail.com>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Create a dependency injection trait named Locker that can be implemented downstream to enable locking of an asset. Use case defined in RMRK substrate pallet PR76 * Formatting * Change impl Locker function name to is_locked * Remove unused import * Add docstring header * Remove impl_locker file and add Locker trait to frame_support::traits * Expose Locker from frame_support::traits::misc * Formatting * Move to tokens folder * Move to tokens folder * Format and remove Locker from misc traits * Punctuation * Update frame/support/src/traits/tokens/misc.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> Co-authored-by: Giles Cope <gilescope@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Within the RMRK Standard there requires a locking mechanism for the NFT to ensure that when a NFT is
listed in thermrk-marketpallet, the NFT must be locked and can no longer allow any interactions with the NFT. Since the RMRK pallet extends theuniquespallet, implementing theLockertrait in the config ofrmrk-corecreates a situation where a user can bypass thelockand execute ado_transferdirectly to theuniquespallet. We looked using thefreezemechanism for anassetinstance, but the implementation was not feasible and led to some centralized problems if the RMRK Admin were to be defined as thefreezerfor all NFT collections.The proposal here is to create a dependency injection trait named
Lockerin theuniquespallet config that has aimplofLockerfor()that has function namedshould_check_lockthat defaults a return offalse, but can be implemented downstream for a pallet like RMRK to enable a simple locking mechanism to ensure the lock cannot be bypassed by directly calling theuniquespalletdo_transfer. A working example of this in the RMRK pallet is defined here.Note
Use case defined in RMRK substrate pallet in this PR: rmrk-team/rmrk-substrate#76 where the code currently is pointing to a branch off of the stable branch version of
v0.19.17with the same changes as this PR. This is my first PR to Substrate so let me know if I may have missed any details and I'll gladly add them. Thank you.cumulus-companion: paritytech/cumulus#1085