This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Fix lazy batch contract removal #10728
Merged
paritytech-processbot
merged 8 commits into
paritytech:master
from
pmikolajczyk41:piomiko/fix-batch-deletion
Jan 28, 2022
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ff1f753
Fix lazy batch contract removal
pmikolajczyk41 fce3ecb
Apply suggestions
pmikolajczyk41 3ce7919
Qualify ChildInfo
pmikolajczyk41 b38abb6
Negligible change to restart pipeline
pmikolajczyk41 83816d2
Revert "Negligible change to restart pipeline"
pmikolajczyk41 d94ad41
Merge remote-tracking branch 'origin/master' into piomiko/fix-batch-d…
pmikolajczyk41 9e33705
Merge branch 'master' of https://github.com/paritytech/substrate into…
289261e
cargo run --quiet --profile=production --features=runtime-benchmarks…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this end up terminating the contract?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you look at the code in
fixtures/self_destruct.wat
then you should find the information, that by passing empty input to thte contract, it will callseal_terminate
. And as far as I can understand text wasm format it does so :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. The contract terminates if called with an empty input.