Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

CountedNMap implementation #10621

Merged
merged 71 commits into from
Aug 4, 2023

Conversation

Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Jan 10, 2022

add CountedStorageNMap implementation which is similar as CountedStorageMap for StorageMap but for the StorageNMap
#10602

polkadot address: 16GBceb9xiWB1R5YQGRfEYDZbWcatmLz8MPd6KZYpy4qfV7B

@Mr-Leshiy
Copy link
Contributor Author

Mr-Leshiy commented Feb 11, 2022

@bkchr , @shawntabrizi don't want to be tactless, but can we proceed with this PR, it will be helpful to solve this issue paritytech/polkadot-sdk#316. Also after if this PR will be approved and merged I will prepare the same update for the StorageNMap.

@kianenigma kianenigma added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Mar 19, 2022
@kianenigma
Copy link
Contributor

This PR seems valuable, yet hat slipped through the crack. Partially due to lack of labeling and project assignment from our side. Hopefully will get some review soon. Thanks @Mr-Leshiy!

@jasl
Copy link
Contributor

jasl commented Jul 31, 2023

kindly ping

@juangirini
Copy link
Contributor

bot fmt

@command-bot
Copy link

command-bot bot commented Jul 31, 2023

@juangirini https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3298354 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 4-d8960438-2c53-404a-965d-8c59ae22d0ed to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jul 31, 2023

@juangirini Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3298354 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3298354/artifacts/download.

@juangirini
Copy link
Contributor

@Mr-Leshiy please note that there are some formatting issues that bot fmt is not able to solve. Could you please look into that?

@jasl
Copy link
Contributor

jasl commented Aug 2, 2023

@juangirini
Sorry for bothering you, but is this mergeable now?

@juangirini
Copy link
Contributor

@sam0x17 @KiChjang There were some changes since your las reviews, would you give it another look before merging?

@jasl
Copy link
Contributor

jasl commented Aug 4, 2023

Could it be merged? this is really an awesome feature

@juangirini
Copy link
Contributor

bot merge

@paritytech-processbot
Copy link

Error: Statuses failed for 4c29a0e

@juangirini
Copy link
Contributor

bot rebase

@paritytech-processbot
Copy link

Rebased

@juangirini
Copy link
Contributor

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit a6b0d43 into paritytech:master Aug 4, 2023
4 checks passed
@Mr-Leshiy Mr-Leshiy deleted the counted-double-map branch August 4, 2023 16:31
@kianenigma
Copy link
Contributor

/tip medium

@substrate-tip-bot
Copy link

@Mr-Leshiy Contributor did not properly post their account address.

Make sure the pull request description (or user bio) has: "{network} address: {address}".

@kianenigma
Copy link
Contributor

@Mr-Leshiy interested in a tip?

@Mr-Leshiy
Copy link
Contributor Author

@kianenigma would be great :)
16GBceb9xiWB1R5YQGRfEYDZbWcatmLz8MPd6KZYpy4qfV7B

@juangirini
Copy link
Contributor

/tip medium

@substrate-tip-bot
Copy link

@juangirini A medium (80 DOT) tip was successfully submitted for @Mr-Leshiy (16GBceb9xiWB1R5YQGRfEYDZbWcatmLz8MPd6KZYpy4qfV7B on polkadot).

https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polkadot.io#/referenda tip

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

CountedDoubleMap, CountedNMap implementation missing