This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
[DO NOT MERGE] Test drive pipeline-scripts#19 #10496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joao-paulo-parity
requested review from
kianenigma and
a team
as code owners
joao-paulo-parity
added
B0-silent
|
For check-dependent-cumulus, the Polkadot companion was patched into Cumulus and so the scenario from #10496 (comment) worked as intended. Meanwhile the "simple case" of check-dependent-polkadot still works as expected. |
joao-paulo-parity
force-pushed
the
jp/companions-script
branch
from
b7abf08 to
2e7ab35
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup for this scenario:
BenchmarkErrorBenchmarkErrortoBenchmarkErrorFoowhich causes a downstream breakage on PolkadotIn the situation above, the script should patch the Polkadot companion into Cumulus as suggested by paritytech/pipeline-scripts#3 (comment)
polkadot companion: paritytech/polkadot#4531
related to paritytech/pipeline-scripts#19