This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Set current dir at check_wasm_toolchain_installed at wasm-builder #10284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MOZGIII
changed the title
bkchr
approved these changes
Nov 17, 2021
bkchr
added
A2-insubstantial
bkchr
reviewed
Nov 17, 2021
| @@ -120,6 +120,7 @@ fn check_wasm_toolchain_installed( | |||
| let manifest_path = temp.path().join("Cargo.toml").display().to_string(); | |||
|
|
|||
| let mut build_cmd = cargo_command.command(); | |||
| build_cmd.current_dir(&temp); | |||
There was a problem hiding this comment.
Could you please add a comment here for what this is.
|
And please merge master to make cargo fmt happy. |
|
Code review comments addressed, ready to proceed. |
bkchr
added
the
D3-trivial 🧸
|
bot merge |
|
Waiting for commit status. |
|
Bot will approve on the behalf of @bkchr, since they are a team lead, in an attempt to reach the minimum approval count |
![paritytech-processbot[bot]](https://avatars.githubusercontent.com/in/144942?s=60&v=4){kind=small}
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
…ritytech#10284) * Set current dir at check_wasm_toolchain_installed * Add comments
bernardo-xxnet
pushed a commit
to xx-labs/substrate
that referenced
this pull request
May 26, 2022
…ritytech#10284) * Set current dir at check_wasm_toolchain_installed * Add comments
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
…ritytech#10284) * Set current dir at check_wasm_toolchain_installed * Add comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an addition to #9926, #9926 (comment).
This takes care of the case where the project root contains
.cargodir, and the code is executing in Github Actions. Long story short, for some reason with this combination, the project's.cargo/config.tomlis picked up.This change makes it work.