Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Allow pallet error enum variants to contain fields #10242

Merged
merged 83 commits into from
Mar 24, 2022
Merged

Allow pallet error enum variants to contain fields #10242

merged 83 commits into from
Mar 24, 2022

Commits on Nov 11, 2021

  1. Allow pallet errors to contain at most one field

    @KiChjang
    KiChjang committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    e569450 View commit details
    Browse the repository at this point in the history

  2. Update docs on pallet::error

    @KiChjang
    KiChjang committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    c4f7b51 View commit details
    Browse the repository at this point in the history

  3. Reword documentation

    @KiChjang
    KiChjang committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    788ea42 View commit details
    Browse the repository at this point in the history

  4. cargo fmt

    @KiChjang
    KiChjang committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    0b70512 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. Introduce CompactPalletError trait and require #[pallet::error] field… 

    …s to implement them
    @KiChjang
    KiChjang committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    d3e5c7c View commit details
    Browse the repository at this point in the history

  2. cargo fmt

    @KiChjang
    KiChjang committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    e8f6714 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2021

  1. Do not assume tuple variants

    @KiChjang
    KiChjang committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    815a616 View commit details
    Browse the repository at this point in the history

  2. Add CompactPalletError derive macro

    @KiChjang
    KiChjang committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    78ff9af View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2021

  1. Check for error type compactness in construct_runtime

    @KiChjang
    KiChjang committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    e86c2d9 View commit details
    Browse the repository at this point in the history

  2. cargo fmt

    @KiChjang
    KiChjang committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    2ba5c5b View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. Derive CompactPalletError instead of implementing it directly during … 

    …macro expansion
    @KiChjang
    KiChjang committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    217e1a4 View commit details
    Browse the repository at this point in the history

  2. Implement CompactPalletError on OptionBool instead of Option<bool>

    @KiChjang
    KiChjang committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    3a399b6 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2021

  1. Check for type idents instead of variant ident

    @KiChjang
    KiChjang committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    a583025 View commit details
    Browse the repository at this point in the history

  2. Add doc comments for ErrorCompactnessTest

    @KiChjang
    KiChjang committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    e68ba71 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2021

  1. Add an trait implementation of ErrorCompactnessTest for ()

    @KiChjang
    KiChjang committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    ed643ff View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2021

  1. Merge remote-tracking branch 'origin/master' into kckyeung/nested-pal… 

    …let-error-enum
    @KiChjang
    KiChjang committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    dcddc79 View commit details
    Browse the repository at this point in the history

  2. Convert the error field of DispatchError to a 4-element byte array

    @KiChjang
    KiChjang committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    3913e85 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2021

  1. Add static check for pallet error size

    @KiChjang
    KiChjang committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    26b0adf View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2021

  1. Rename to MAX_PALLET_ERROR_ENCODED_SIZE

    @KiChjang
    KiChjang committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    82c29a9 View commit details
    Browse the repository at this point in the history

  2. Remove ErrorCompactnessTest trait

    @KiChjang
    KiChjang committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    a1a0c32 View commit details
    Browse the repository at this point in the history

  3. Remove check_compactness

    @KiChjang
    KiChjang committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    0fb5860 View commit details
    Browse the repository at this point in the history

  4. Return only the most significant byte when constructing a custom Inva… 

    …lidTransaction
    @KiChjang
    KiChjang committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    69753e9 View commit details
    Browse the repository at this point in the history

  5. Rename CompactPalletError to PalletError

    @KiChjang
    KiChjang committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    c57ccb6 View commit details
    Browse the repository at this point in the history

  6. Use counter to generate unique idents for assert macros

    @KiChjang
    KiChjang committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    f6f8be5 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2021

  1. Make declarative pallet macros compile with pallet error size checks

    @KiChjang
    KiChjang committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    9b92379 View commit details
    Browse the repository at this point in the history

  2. Remove unused doc comment

    @KiChjang
    KiChjang committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    b984433 View commit details
    Browse the repository at this point in the history

  3. Try and fix build errors

    @KiChjang
    KiChjang committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    2fb09fb View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2021

  1. Fix build errors

    @KiChjang
    KiChjang committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    adceb34 View commit details
    Browse the repository at this point in the history

  2. Add macro_use for some test modules

    @KiChjang
    KiChjang committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    b018d42 View commit details
    Browse the repository at this point in the history

  3. Test fix

    @KiChjang
    KiChjang committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    56ff09d View commit details
    Browse the repository at this point in the history

  4. Fix compilation errors

    @KiChjang
    KiChjang committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    29841d9 View commit details
    Browse the repository at this point in the history

  5. Remove unneeded #[macro_use]

    @KiChjang
    KiChjang committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    1ca9680 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/master' into kckyeung/nested-pal… 

    …let-error-enum
    @KiChjang
    KiChjang committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    cf1cbd3 View commit details
    Browse the repository at this point in the history

  7. Resolve import ambiguity

    @KiChjang
    KiChjang committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    b7c2b9f View commit details
    Browse the repository at this point in the history

  8. Make path to pallet Error enum more specific

    @KiChjang
    KiChjang committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    8783da5 View commit details
    Browse the repository at this point in the history

  9. Fix test expectation

    @KiChjang
    KiChjang committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    1f991ff View commit details
    Browse the repository at this point in the history

  10. Disambiguate imports

    @KiChjang
    KiChjang committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    d7e3597 View commit details
    Browse the repository at this point in the history

  11. Fix test expectations

    @KiChjang
    KiChjang committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    aea23e0 View commit details
    Browse the repository at this point in the history

  12. Revert appending pallet module name to path

    @KiChjang
    KiChjang committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    1a4bcdf View commit details
    Browse the repository at this point in the history

  13. Rename bags_list::list::Error to BagError

    @KiChjang
    KiChjang committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    d2e42ef View commit details
    Browse the repository at this point in the history

  14. Fixes

    @KiChjang
    KiChjang committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    9ab1b56 View commit details
    Browse the repository at this point in the history

  15. Fixes

    @KiChjang
    KiChjang committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    1be3227 View commit details
    Browse the repository at this point in the history

  16. Fixes

    @KiChjang
    KiChjang committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    0342859 View commit details
    Browse the repository at this point in the history

  17. Fix test expectations

    @KiChjang
    KiChjang committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    066ec5f View commit details
    Browse the repository at this point in the history

  18. Fix test expectation

    @KiChjang
    KiChjang committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    1f3ab67 View commit details
    Browse the repository at this point in the history

  19. Add more implementations for PalletError

    @KiChjang
    KiChjang committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    b45ca96 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2021

  1. Lift the 1-field requirement for nested pallet errors

    @KiChjang
    KiChjang committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    981a29f View commit details
    Browse the repository at this point in the history

  2. Fix UI test expectation

    @KiChjang
    KiChjang committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    0ef2812 View commit details
    Browse the repository at this point in the history

  3. Remove PalletError impl for OptionBool

    @KiChjang
    KiChjang committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    fb1b32b View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2021

  1. Use saturating operations

    @KiChjang
    KiChjang committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    fb73b33 View commit details
    Browse the repository at this point in the history

  2. cargo fmt

    @KiChjang
    KiChjang committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    8e8a27a View commit details
    Browse the repository at this point in the history

  3. Delete obsolete test

    @KiChjang
    KiChjang committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    2a54736 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2021

  1. Fix test expectation

    @KiChjang
    KiChjang committed Dec 24, 2021
    Configuration menu
    Copy the full SHA
    a250788 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2022

  1. Merge remote-tracking branch 'origin/master' into kckyeung/nested-pal… 

    …let-error-enum
    @KiChjang
    KiChjang committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    7d80dae View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2022

  1. Try and use assert macro in const context

    @KiChjang
    KiChjang committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    c44e6e4 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2022

  1. Pull out the pallet error size check macro

    @KiChjang
    KiChjang committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    cc06206 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into kckyeung/nested-pal… 

    …let-error-enum
    @KiChjang
    KiChjang committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    c037c6d View commit details
    Browse the repository at this point in the history

  3. Fix UI test for const assertion

    @KiChjang
    KiChjang committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    e4c3f47 View commit details
    Browse the repository at this point in the history

  4. cargo fmt

    @KiChjang
    KiChjang committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    fa0e155 View commit details
    Browse the repository at this point in the history

  5. Apply clippy suggestion

    @KiChjang
    KiChjang committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    29e3df1 View commit details
    Browse the repository at this point in the history

  6. Fix doc comment

    @KiChjang
    KiChjang committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    a8b6214 View commit details
    Browse the repository at this point in the history

  7. Docs for create_tt_return_macro

    @KiChjang
    KiChjang committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    cca5ed6 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2022

  1. Ensure TryInto is imported in earlier Rust editions

    @KiChjang
    KiChjang committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    52a0a73 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
    @KiChjang @bkchr
    KiChjang and bkchr authored Feb 11, 2022
    Configuration menu
    Copy the full SHA
    ece305e View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2022

  1. Fix up comments and names

    @KiChjang
    KiChjang committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    29a131a View commit details
    Browse the repository at this point in the history

  2. Implement PalletError for Never

    @KiChjang
    KiChjang committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    9cdf1aa View commit details
    Browse the repository at this point in the history

  3. cargo fmt

    @KiChjang
    KiChjang committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    5070335 View commit details
    Browse the repository at this point in the history

  4. Don't compile example code

    @KiChjang
    KiChjang committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    ac1f198 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2022

  1. Bump API version for block builder

    @KiChjang
    KiChjang committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    811e2f2 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2022

  1. Factor in codec attributes while derving PalletError

    @KiChjang
    KiChjang committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    7595123 View commit details
    Browse the repository at this point in the history

  2. Rename module and fix unit test

    @KiChjang
    KiChjang committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    89abef7 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2022

  1. Add missing attribute

    @KiChjang
    KiChjang committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    161fb88 View commit details
    Browse the repository at this point in the history

  2. Check API version and convert ApplyExtrinsicResult accordingly

    @KiChjang
    KiChjang committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    babebfc View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into kckyeung/nested-pal… 

    …let-error-enum
    @KiChjang
    KiChjang committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    80ed571 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2022

  1. Rename BagError to ListError 

    Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
    @KiChjang @kianenigma
    KiChjang and kianenigma authored Mar 17, 2022
    Configuration menu
    Copy the full SHA
    7fed725 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2022

  1. Merge remote-tracking branch 'origin/master' into kckyeung/nested-pal… 

    …let-error-enum
    @KiChjang
    KiChjang committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    8d25a2f View commit details
    Browse the repository at this point in the history

  2. Use codec crate re-exported from frame support

    @KiChjang
    KiChjang committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    9fef2e1 View commit details
    Browse the repository at this point in the history

  3. Add links to types mentioned in doc comments 

    Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
    @KiChjang @bkchr
    KiChjang and bkchr authored Mar 20, 2022
    Configuration menu
    Copy the full SHA
    ddc2cce View commit details
    Browse the repository at this point in the history

  4. cargo fmt

    @KiChjang
    KiChjang committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    23608e7 View commit details
    Browse the repository at this point in the history

  5. cargo fmt

    @KiChjang
    KiChjang committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    9d0dfa7 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2022

  1. Merge branch 'master' into kckyeung/nested-pallet-error-enum

    @KiChjang
    KiChjang authored Mar 21, 2022
    Configuration menu
    Copy the full SHA
    966b177 View commit details
    Browse the repository at this point in the history

  2. Re-add attribute for hidden docs

    @KiChjang
    KiChjang committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    2b3b730 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2022

  1. Merge remote-tracking branch 'origin/master' into kckyeung/nested-pal… 

    …let-error-enum
    @KiChjang
    KiChjang committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    f4157f4 View commit details
    Browse the repository at this point in the history