This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
put TryInto and TryFrom in sp_std::prelude
#10183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianenigma
changed the title
TryInto and TryFrom in sp_std::prelude
kianenigma
changed the title
TryInto and TryFrom in sp_std::preludeTryInto and TryFrom in sp_std::prelude
|
It does not compile :P |
bkchr
approved these changes
Nov 5, 2021
shawntabrizi
approved these changes
Nov 5, 2021
kianenigma
added
B0-silent
athei
approved these changes
Nov 5, 2021
|
bot merge |
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Waiting on code owner review from andresilva. |
|
bot merge force |
|
Error: Waiting on code owner review from andresilva. |
|
I think this new rule is a bit too much, specially for substrate-node, but anyway 🤷 |
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* Switch to Rust 2021 * Update trybuild to fix errors * half baked * fix * remove unused import * remove more warnings Co-authored-by: Bastian Köcher <info@kchr.de>
AurevoirXavier
added a commit
to darwinia-network/darwinia-common
that referenced
this pull request
Aug 4, 2022
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Switch to Rust 2021 * Update trybuild to fix errors * half baked * fix * remove unused import * remove more warnings Co-authored-by: Bastian Köcher <info@kchr.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
given #10170, we can drop a lot of imports, assuming that we also add these traits to our prelude.
Fixes ##10181