This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Regression in output of sync_state_genSyncSpec #11435
Comments
oops, sorry let me have a look |
Note that I haven't actually checked what the function was returning before the PR (I have only checked the after). However we have a script that started failing after the PR has been deployed, and this script is directly expecting an object instead of a string, so what I wrote is the only possible explanation. |
you are correct, it returned one sec, I think we need to block the current release for this right? |
chevdor
pushed a commit
that referenced
this issue
May 17, 2022
* fix: #11435 * address grumbles: better safe than sorry
chevdor
added a commit
that referenced
this issue
May 18, 2022
* fix: #11435 * address grumbles: better safe than sorry Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
godcodehunter
pushed a commit
to sensoriumxr/substrate
that referenced
this issue
Jun 22, 2022
…ech#11437) * fix: paritytech#11435 * address grumbles: better safe than sorry
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this issue
Aug 23, 2022
…ech#11437) * fix: paritytech#11435 * address grumbles: better safe than sorry
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this issue
Feb 27, 2023
…ech#11437) * fix: paritytech#11435 * address grumbles: better safe than sorry
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Before #8783, calling the
sync_state_genSyncSpec
JSON-RPC function would return something like this:After the PR, the output looks like this:
In other words, the result has been stringified.
cc @niklasad1
The text was updated successfully, but these errors were encountered: