Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Copy weight files into node-template #11090

Closed
ggwpez opened this issue Mar 22, 2022 · 2 comments
Closed

Copy weight files into node-template #11090

ggwpez opened this issue Mar 22, 2022 · 2 comments
Labels
I7-refactor Code needs refactoring. U4-some_day_maybe Issue might be worth doing eventually. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder

Comments

@ggwpez
Copy link
Member

ggwpez commented Mar 22, 2022

Analogous to paritytech/polkadot#5064
Instead of using the default weights from frame_support, copy the files over to encourage developers to benchmark their own weights.
Concretely block_weight.rs, extrinsic_weight.rs, rocksdb_weight.rs and paritydb_weight.rs.

The parachain template needs this as well.

@ggwpez ggwpez added I7-refactor Code needs refactoring. U4-some_day_maybe Issue might be worth doing eventually. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder labels Mar 22, 2022
tifecool added a commit to tifecool/substrate that referenced this issue Mar 23, 2022
tifecool added a commit to tifecool/substrate that referenced this issue Mar 24, 2022
tifecool added a commit to tifecool/substrate that referenced this issue Mar 24, 2022
@bkchr
Copy link
Member

bkchr commented Apr 7, 2022

@shawntabrizi so we can also close this issue?

@shawntabrizi
Copy link
Member

Yes. My opinion at this moment is that the node template should be minimal, and just point to the "default substrate weights" for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I7-refactor Code needs refactoring. U4-some_day_maybe Issue might be worth doing eventually. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder
Projects
Development

No branches or pull requests

3 participants