Rutger/fix user error trace #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The polkadot node does not listen on the IPv6 localhost by default. This caused failures on systems that resolve localhost to ::1
Enables proper functioning in environments that do not use env vars. Previously the lack of this caused issues in localtest environments.
rzadp
approved these changes
Feb 17, 2023
mordamax
reviewed
Feb 17, 2023
| @@ -95,7 +95,7 @@ export async function tipUser( | |||
| unsub(); | |||
| } | |||
| }); | |||
|
|
|||
| await api.disconnect(); | |||
There was a problem hiding this comment.
does this solve the reconnection or runtime upgrade issue?
There was a problem hiding this comment.
No, But I am hoping this will solve the memory leak issue that was reported.
mordamax
reviewed
Feb 17, 2023
| try { | ||
| tipSize = getTipSize(tipSizeInput); | ||
| } catch (error) { | ||
| return error.message; |
There was a problem hiding this comment.
That covers only these 2 methods, but it doesn't for example tipUser or anything else.
I would propose to look into how respondOnResult writes the message in ALL cases, and make sure the trace isn't printed there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32 by improving error handling
Changes localhost to 127.0.0.1 for IPv4 only localtest
Include dotenv config to fix local testing environment