Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment with a link to Polkassembly referendum #141

Merged
merged 14 commits into from
Feb 23, 2024
Merged

Comment with a link to Polkassembly referendum #141

merged 14 commits into from
Feb 23, 2024

Conversation

rzadp
Copy link
Contributor

@rzadp rzadp commented Feb 16, 2024 •
edited
Loading

Closes #113

  • Move Polkassemby-updating function invocation up the stack, and add matrix&github notifications.
  • Replace a useless link to polkadot-js-apps referenda in the github comment with a referendum number.

@rzadp rzadp changed the title [Draft] Comment with a link to Polkassembly referendum Comment with a link to Polkassembly referendum Feb 21, 2024
@rzadp rzadp marked this pull request as ready for review February 21, 2024 15:56
@rzadp rzadp requested a review from a team as a code owner February 21, 2024 15:56
@rzadp
Copy link
Contributor Author

rzadp commented Feb 21, 2024

@paritytech/opstooling Ready for review.

mordamax
mordamax approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@mordamax mordamax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

@rzadp rzadp merged commit 6b01635 into master Feb 23, 2024
8 checks passed
@rzadp rzadp deleted the rzadp/pa-link branch February 23, 2024 11:00
@rzadp rzadp mentioned this pull request Feb 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mordamax mordamax mordamax approved these changes

@mutantcornholio mutantcornholio Awaiting requested review from mutantcornholio

@Bullrich Bullrich Awaiting requested review from Bullrich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Respond with a link to Polkassembly
2 participants
@rzadp @mordamax