Merge pull request #165 from paritytech/rzadp/test

Allow for more permissive user input

src/bot-handle-comment.ts

@@ -127,7 +127,7 @@ export const handleTipRequest = async (
     return { success: false, errorMessage: `@${contributorLogin} ${contributorAccount.error}` };
   }
 
-  const tipSize = getTipSize(tipSizeInput);
+  const tipSize = getTipSize(tipSizeInput?.trim());
   if (typeof tipSize == "object" && "error" in tipSize) {
     return { success: false, errorMessage: `@${tipRequester} ${tipSize.error}` };
   }

src/util.test.ts

@@ -13,6 +13,37 @@ describe("Utility functions", () => {
       expect(result.address).toEqual(address);
     });
 
+    test("allows uppercase", () => {
+      const address = randomAddress();
+      const result = parseContributorAccount([`Kusama Address: ${address}`]);
+      if ("error" in result) {
+        throw new Error(result.error);
+      }
+      expect(result.network).toEqual("kusama");
+      expect(result.address).toEqual(address);
+    });
+
+    test("allows whitespace", () => {
+      const address = randomAddress();
+      const result = parseContributorAccount([`\nkusama Address: ${address}\n\n`]);
+      if ("error" in result) {
+        throw new Error(result.error);
+      }
+      expect(result.network).toEqual("kusama");
+      expect(result.address).toEqual(address);
+    });
+
+    // Some people naturally put backticks aronud the address.
+    test("allows backticks around the address", () => {
+      const address = randomAddress();
+      const result = parseContributorAccount([`Kusama Address: \`${address}\``]);
+      if ("error" in result) {
+        throw new Error(result.error);
+      }
+      expect(result.network).toEqual("kusama");
+      expect(result.address).toEqual(address);
+    });
+
     test("Returns error message when cannot parse", () => {
       const address = randomAddress();
       const result = parseContributorAccount([`kusama: ${address}`]);

src/util.ts

@@ -76,7 +76,7 @@ export function parseContributorAccount(bodys: (string | null)[]): ContributorAc
       typeof body === "string" &&
       body.match(
         // match "polkadot address: <ADDRESS>"
-        /(\S+)\s*address:\s*([a-z0-9]+)/i,
+        /(\S+)\s*address:\s*`?([a-z0-9]+)`?/i,
       );
 
     if (matches === false || matches === null || matches.length != 3) {