Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make releases EZ #279

Merged
merged 7 commits into from
May 20, 2021
Merged

Make releases EZ #279

merged 7 commits into from
May 20, 2021

Conversation

insipx
Copy link
Collaborator

@insipx insipx commented May 20, 2021

PR adds a github action workflow which automates releases. It will run whenever the branch release gets pushed to. Once it's pushed to, the workflow:

  • Builds polkadot-archive in --release, packages binary in .deband also standalone linux (as with all previous releases)
  • Reads from Changelog to fill in release notes in body of release, as well as assign release tag & name

This PR also fixes CHANGELOG to follow keep a changelog, and creates a separate CHANGELOG for polkadot-archive. This will make it easier to update in the future I think.

This won't publish the release, but it will create a draft that we can look over and modify and then publish from Github UI. This is my preferred way, just because it forces double-checking things, but I'm open to other opinions

I suspect this could further be automated by adding a dienerstep to automatically change all substrate/polkadot refs to the latest release with some more github-action magic.

I was testing this stuff out earlier in a personal repo before creating the action (Release branch): https://github.com/insipx/test-gh-action

Andrew Plaza added 4 commits May 19, 2021 16:23
@insipx insipx requested review from dvdplm and emostov May 20, 2021 04:03
Copy link
Contributor

@emostov emostov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good from what I understand; just a question about how the changelog reader knows how to get the version. Is there a way to test without actually merging to the release branch?

Copy link

@maciejhirsz maciejhirsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing found.

RELEASE-CHECKLIST.md Outdated Show resolved Hide resolved
RELEASE-CHECKLIST.md Outdated Show resolved Hide resolved
Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks cool.

Co-authored-by: Tarik Gul <47201679+TarikGul@users.noreply.github.com>
@insipx insipx merged commit 9abef6e into master May 20, 2021
@insipx insipx deleted the insipx/automate-release branch June 4, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants