-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use stable toolchain as default for ink! related CI images #453
Conversation
Won't this break the ink! CI? Building ink! itself (when not done by |
You're right, I got too excited 😆 This change could still work but we'd need to manually set |
I would say merge this but change the ink! CI to put |
Okay that makes sense. We can also use Footnotes
|
This will let us build `ink!` crates for this target using `RUSTC_BOOTSTRAP=1`.
You could still tell developers to use nightly for local development. But the CI should use stable cause that is what we are delivering to our users. |
If it were up to me we'd to spaces, but for consistency's sake I'm using tabs
After use-ink/cargo-contract#698 we're able to build contracts
using the stable toolchain instead of nightly.
This updates our CI images to use stable as the default toolchain.