Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: do not run bun tests #215

Merged
merged 3 commits into from
Feb 17, 2025
Merged

ci: do not run bun tests #215

merged 3 commits into from
Feb 17, 2025

Conversation

xermicus
Copy link
Member

@xermicus xermicus commented Feb 17, 2025

They are too flaky. Culprit: oven-sh/bun#17146

Updates some JS dependencies as a drive-by.

Signed-off-by: xermicus <cyrill@parity.io>
@xermicus xermicus changed the title bump bun version ci: bump bun version Feb 17, 2025
Signed-off-by: xermicus <cyrill@parity.io>
@xermicus xermicus changed the title ci: bump bun version ci: don not run bun tests Feb 17, 2025
@xermicus xermicus changed the title ci: don not run bun tests ci: do not run bun tests Feb 17, 2025
@xermicus xermicus requested a review from smiasojed February 17, 2025 13:27
@athei
Copy link
Member

athei commented Feb 17, 2025

Shouldn't we just use a non broken runtime, instead? Would it be hard to port to node?

@xermicus
Copy link
Member Author

@athei FYI the PR pivoted already to do exactly that (originally I thought it was fixed with upgraded bun because the error went away locally after upgrading bun but then I got remember of the underlying issue).

Copy link
Member

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we are running the tests using node anyways? We just removed the additional run via bun?

@@ -118,16 +117,9 @@ jobs:
run: |
Set-ExecutionPolicy RemoteSigned -Scope CurrentUser
iex (new-object net.webclient).downloadstring('https://get.scoop.sh')
scoop install bun@${{ env.BUN_VERSION }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name of the job still correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch thanks! I probably should have removed the whole thing instead.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that you need to keep wget

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah so it wasn't used only for downloading bun?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wget was used to download soljson compiler in the past, but looks like it is not used anymore. Should be fine

@xermicus
Copy link
Member Author

Yes. I'd still like to keep the bun scripts around. But there's no need to run them on the CI for now since we know bun doesn't work well at this point.

Signed-off-by: xermicus <cyrill@parity.io>
@xermicus xermicus merged commit a73b092 into main Feb 17, 2025
6 checks passed
@xermicus xermicus deleted the cl/bump-bun branch February 17, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants