-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: do not run bun tests #215
Conversation
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
Shouldn't we just use a non broken runtime, instead? Would it be hard to port to |
@athei FYI the PR pivoted already to do exactly that (originally I thought it was fixed with upgraded bun because the error went away locally after upgrading bun but then I got remember of the underlying issue). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we are running the tests using node anyways? We just removed the additional run via bun?
@@ -118,16 +117,9 @@ jobs: | |||
run: | | |||
Set-ExecutionPolicy RemoteSigned -Scope CurrentUser | |||
iex (new-object net.webclient).downloadstring('https://get.scoop.sh') | |||
scoop install bun@${{ env.BUN_VERSION }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name of the job still correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch thanks! I probably should have removed the whole thing instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that you need to keep wget
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah so it wasn't used only for downloading bun?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wget was used to download soljson compiler in the past, but looks like it is not used anymore. Should be fine
Yes. I'd still like to keep the bun scripts around. But there's no need to run them on the CI for now since we know bun doesn't work well at this point. |
Signed-off-by: xermicus <cyrill@parity.io>
They are too flaky. Culprit: oven-sh/bun#17146
Updates some JS dependencies as a drive-by.