Automated deployment #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mordamax
reviewed
Sep 5, 2023
Comment on lines
+368
to
+371
| To deploy a new version you need to update two files: | ||
| - [`package.json`](./package.json): Update the version number. | ||
| - [`action.yml`](./action.yml): Update the image number in `runs.image`. | ||
| **Important**: Both versions must have the same number. |
There was a problem hiding this comment.
it could be done with some release script?
yarn version which should update package.json + action could be done with awk + regex?
There was a problem hiding this comment.
It can be done. I just didn't think that investing the time on writing a script to replace two strings is worth the effort as the change is minimal. But I can look into adding some script to do that.
Or would it be fine if I move it into a different ticket?
mordamax
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created deploy script to automatically deploy new versions to GitHub packages using Docker.
The deployment was copied from stale-pr-finder/.github/workflows/publish.yml
Closes #55