Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent review request #64

Merged
merged 10 commits into from
Aug 31, 2023
Merged

Prevent review request #64

merged 10 commits into from
Aug 31, 2023

Conversation

Bullrich
Copy link
Collaborator

@Bullrich Bullrich commented Aug 29, 2023

Added the feature Prevent review request

Thie resolves #59.

It allows us to not request the review of some teams or users.

As we don't have the request review implementation yet (see #53), I didn't add any explanation in the README.

@Bullrich Bullrich added this to the Project launch milestone Aug 29, 2023
@Bullrich Bullrich self-assigned this Aug 29, 2023
@Bullrich Bullrich requested a review from a team as a code owner August 29, 2023 15:37
@Bullrich Bullrich linked an issue Aug 29, 2023 that may be closed by this pull request
@rzadp
Copy link
Contributor

rzadp commented Aug 30, 2023

I'm confused by this, in the pr-custom-review repo prevent_review_request is described as an option to not request a review.

And this seems to be doing something entirely different - greenlighting authors to skip the checks.
Is that actually what we want?

@Bullrich Bullrich enabled auto-merge (squash) August 31, 2023 14:22
@Bullrich Bullrich merged commit d8b2e9f into main Aug 31, 2023
14 checks passed
@Bullrich Bullrich deleted the prevent-review-request branch August 31, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add prevent_review_request field
3 participants