Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created "and" rule #44

Merged
merged 18 commits into from
Aug 11, 2023
Merged

Created "and" rule #44

merged 18 commits into from
Aug 11, 2023

Conversation

Bullrich
Copy link
Collaborator

@Bullrich Bullrich commented Aug 9, 2023 •
edited
Loading

Changes

  • Created the AND rule with a configuration.
    • This resolves Create AND rule #10
    • Created the type for it
    • Created the JOI validation
      • It must have at least two individual conditions for it to be valid so it is not used as a basic rule.
  • Fixed bug where check summary duplicated content
    • This happened because it has a buffer and I had to empty it.
  • Created AND rule evaluation for pull requests.
    • It combines its report into one.
  • Fixed bug where author appeared as one of the missing reviews
  • Created tests for AND rule.
  • Renamed files and directories
    • file directory now is rule directory (as it store the types and validations for the clases)

@Bullrich Bullrich added this to the Project launch milestone Aug 9, 2023
@Bullrich Bullrich self-assigned this Aug 9, 2023
@Bullrich Bullrich requested a review from a team as a code owner August 9, 2023 09:49
@Bullrich Bullrich marked this pull request as draft August 9, 2023 09:49
@Bullrich Bullrich changed the title Created and rule Created "and" rule Aug 9, 2023
@Bullrich Bullrich force-pushed the and-rule branch 4 times, most recently from 04ccbc5 to c2c1369 Compare August 9, 2023 12:09
mutantcornholio
mutantcornholio previously approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@mutantcornholio mutantcornholio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing testing

@Bullrich
Copy link
Collaborator Author

@paritytech/opstooling this is ready for review. I had not removed the branch code so you can see how it works on its own branch.

Will be removed at the end (anyways, it is a requirement to make validate-action step success.

@Bullrich Bullrich marked this pull request as ready for review August 10, 2023 09:40
@Bullrich Bullrich dismissed mutantcornholio’s stale review August 10, 2023 09:41

It was used for a test

@Bullrich Bullrich requested review from a team and mutantcornholio August 10, 2023 09:41
mutantcornholio
mutantcornholio previously requested changes Aug 10, 2023
View reviewed changes
src/test/runner/validation/and.test.ts Outdated Show resolved Hide resolved
.github/workflows/review-bot.yml Outdated Show resolved Hide resolved
Bullrich added a commit that referenced this pull request Aug 11, 2023
@Bullrich
Added "and" rule to config file
59076ff 
So it can be evaluated by #44
@Bullrich Bullrich enabled auto-merge (squash) August 11, 2023 14:33
@Bullrich Bullrich merged commit df9a591 into main Aug 11, 2023
8 checks passed
@Bullrich Bullrich deleted the and-rule branch August 11, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzadp rzadp rzadp approved these changes

@mordamax mordamax Awaiting requested review from mordamax

@mutantcornholio mutantcornholio Awaiting requested review from mutantcornholio

Assignees

@Bullrich Bullrich

Labels
None yet
Projects
None yet
Milestone
Project launch
Development

Successfully merging this pull request may close these issues.

Create AND rule
3 participants
@Bullrich @mutantcornholio @rzadp