Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support both users AND teams. #28

Closed
Bullrich opened this issue Jul 25, 2023 · 0 comments · Fixed by #30
Closed

Support both users AND teams. #28

Bullrich opened this issue Jul 25, 2023 · 0 comments · Fixed by #30
Milestone
Project launch

Comments

@Bullrich
Copy link
Collaborator

Originally we support either teams or users as the required reviewers.

This was a misconception of my part. We can support both teams and users. We have to update it to support both.

Originally posted by @mordamax in #23 (comment)
@Bullrich Bullrich added this to the Project launch milestone Jul 25, 2023
This was referenced Jul 25, 2023
Merged
Merged
Bullrich added a commit that referenced this issue Aug 1, 2023
@Bullrich
Fixed user OR teams to users AND teams (#30)
2fca6de 
Fixed the `XOR` condition for a `OR` condition.

Updated tests.

Closes #28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Project launch
Development

Successfully merging a pull request may close this issue.

Fixed user OR teams to users AND teams paritytech/review-bot
1 participant
@Bullrich