Whitelist from benchmarking XCM storage keys read each block #6871

franciscoaguirre · 2023-03-13T15:36:25Z

Added the following XcmPallet storage keys to the benchmark whitelist on all runtimes since they are read every block:

SupportedVersion
VersionDiscoveryQueue
SafeXcmVersion

Addresses #5203

ggwpez · 2023-03-13T16:00:43Z

bot help

ggwpez · 2023-03-13T16:07:09Z

bot clean
bot bench $ runtime polkadot pallet_xcm

runtime/polkadot/src/weights/pallet_xcm.rs

ggwpez · 2023-03-13T17:08:45Z

bot clean
bot bench $ runtime polkadot pallet_xcm
bot bench $ runtime kusama pallet_xcm
bot bench $ runtime westend pallet_xcm

…HEAD

ggwpez · 2023-03-13T19:59:20Z

bot bench $ runtime rococo pallet_xcm
bot clean

…HEAD

runtime/kusama/src/lib.rs

franciscoaguirre · 2023-03-15T10:13:29Z

bot help

franciscoaguirre · 2023-03-15T10:15:01Z

bot clean
bot bench $ runtime polkadot pallet_xcm
bot bench $ runtime kusama pallet_xcm
bot bench $ runtime westend pallet_xcm
bot bench $ runtime rococo pallet_xcm
bot clean

runtime/kusama/src/lib.rs

…HEAD

franciscoaguirre · 2023-04-04T14:50:53Z

bot rebase

franciscoaguirre · 2023-04-04T14:53:08Z

bot rebase

franciscoaguirre · 2023-04-04T22:03:37Z

bot clean

runtime/kusama/src/lib.rs

…ist-xcm-storage

kianenigma · 2023-06-27T09:17:43Z

runtime/parachains/src/configuration.rs

@@ -508,6 +508,7 @@ pub mod pallet {

 	/// The active configuration for the current session.
 	#[pallet::storage]
+	#[pallet::whitelist_storage]


@gupnik one new item for you to add to the pallet macro kitchensink example.

kianenigma

@ggwpez Do we have a way to systematically check that these storage items are included in the base-block weight? How is it even calculated? I presume we initialize an empty block?

Would be good to move this toward being more automated, if possible

franciscoaguirre · 2023-07-02T13:36:09Z

bot rebase

…ound' into cisco-whitelist-xcm-storage

paritytech-processbot · 2023-07-02T13:36:16Z

Rebased

* Add polkadot XCM benchmarks * Add temp * ".git/.scripts/commands/bench/bench.sh" xcm polkadot pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm polkadot pallet_xcm_benchmarks::generic * Add weights to XCM on Polkadot * Make CI fail on old files Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update template Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Add reserve_asset_deposited benchmark * ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::generic * Update weights Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Change initiate_reserve_deposit in runtime weights * Update weights Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Remove trusted reserves from runtimes * Fix pallet-xcm-benchmarks mock * Fix test * Change pallet xcm weigher in kusama * Fix * Remove merge conflict artifact * Remove initiate_reserve_withdraw from generic benchmarks * Add missing implementation to XCM benchmark * Fix failing karura test * Remove dbg! Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> * Fix fmt * Revert "Fix fmt" This reverts commit 676f2d8. * Fix fmt * Remove duplicated template code * Add back part of the template * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm polkadot pallet_xcm_benchmarks::fungible * Don't skip reserve asset deposited benchmark * Remove call to non-generated benchmark yet * Underscore unused parameter * Skip not supported benchmarks and hardcode value * Remove ReserveAssetDeposited benchmark * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm polkadot pallet_xcm_benchmarks::fungible * Add back ReserveAssetDeposited * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm polkadot pallet_xcm_benchmarks::fungible * Use default benchmark for ReserveAssetDeposited * Add missing parameter * Revert reserve asset deposited benchmark * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm kusama pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm westend pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm rococo pallet_xcm_benchmarks::fungible * Add 'real' benchmarks * Add TrustedReserve to actual XcmConfig * Add TrustedReserve to actual XcmConfig (fix) * Whitelist from benchmarking XCM storage keys read each block (#6871) * Whitelist from benchmarking XCM storage keys read each block * ".git/.scripts/commands/bench/bench.sh" runtime polkadot pallet_xcm * ".git/.scripts/commands/bench/bench.sh" runtime polkadot pallet_xcm * ".git/.scripts/commands/bench/bench.sh" runtime westend pallet_xcm * ".git/.scripts/commands/bench/bench.sh" runtime rococo pallet_xcm * Remove XcmPallet SupportedVersion from the benchmark whitelist * ".git/.scripts/commands/bench/bench.sh" runtime polkadot pallet_xcm * ".git/.scripts/commands/bench/bench.sh" runtime kusama pallet_xcm * ".git/.scripts/commands/bench/bench.sh" runtime westend pallet_xcm * ".git/.scripts/commands/bench/bench.sh" runtime rococo pallet_xcm * WIP * Add necessary traits, remove unnecessary whitelisted keys * Fix tests * Remove unused file * Remove unused import --------- Co-authored-by: command-bot <> * ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm rococo pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm westend pallet_xcm_benchmarks::fungible * Fix spellchecker issues * Remove unused migration code --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: command-bot <> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>

Whitelist from benchmarking XCM storage keys read each block

f21e3ef

franciscoaguirre requested review from KiChjang and ggwpez March 13, 2023 15:36

paritytech-ci requested review from a team March 13, 2023 15:36

franciscoaguirre mentioned this pull request Mar 13, 2023

Whitelist from benchmarking XCM storage keys read each block #6844

Closed

".git/.scripts/commands/bench/bench.sh" runtime polkadot pallet_xcm

6c5c8db

ggwpez approved these changes Mar 13, 2023

View reviewed changes

runtime/polkadot/src/weights/pallet_xcm.rs Show resolved Hide resolved

command-bot added 3 commits March 13, 2023 17:09

Merge branch 'master' of https://github.com/paritytech/polkadot into …

f93c640

…HEAD

".git/.scripts/commands/bench/bench.sh" runtime polkadot pallet_xcm

6ab6612

".git/.scripts/commands/bench/bench.sh" runtime westend pallet_xcm

c8f288d

command-bot added 2 commits March 13, 2023 19:59

Merge branch 'master' of https://github.com/paritytech/polkadot into …

5abcb3c

…HEAD

".git/.scripts/commands/bench/bench.sh" runtime rococo pallet_xcm

4249c19

bkchr approved these changes Mar 13, 2023

View reviewed changes

paritytech-ci requested a review from a team March 13, 2023 21:05

ggwpez reviewed Mar 14, 2023

View reviewed changes

runtime/kusama/src/lib.rs Outdated Show resolved Hide resolved

Remove XcmPallet SupportedVersion from the benchmark whitelist

a97194f

KiChjang reviewed Mar 15, 2023

View reviewed changes

runtime/kusama/src/lib.rs Outdated Show resolved Hide resolved

command-bot added 2 commits March 15, 2023 11:11

Merge branch 'master' of https://github.com/paritytech/polkadot into …

ad9c58f

…HEAD

".git/.scripts/commands/bench/bench.sh" runtime polkadot pallet_xcm

d0a78a2

Merge branch 'master' into cisco-whitelist-xcm-storage

6bdc093

command-bot bot deleted a comment from paritytech-processbot bot Apr 4, 2023

KiChjang approved these changes Apr 6, 2023

View reviewed changes

ggwpez reviewed Apr 6, 2023

View reviewed changes

runtime/kusama/src/lib.rs Outdated Show resolved Hide resolved

ggwpez reviewed Apr 6, 2023

View reviewed changes

runtime/kusama/src/lib.rs Show resolved Hide resolved

franciscoaguirre added 5 commits April 7, 2023 22:01

Add necessary traits, remove unnecessary whitelisted keys

aa80b22

Merge branch 'master' into cisco-whitelist-xcm-storage

1861356

Fix tests

344c283

Remove unused file

f982eac

Remove unused import

30287f7

franciscoaguirre requested a review from gavofyork June 15, 2023 10:59

franciscoaguirre changed the base branch from master to cisco-polkadot-xcm-weight-info-bound June 23, 2023 16:18

Merge branch 'cisco-polkadot-xcm-weight-info-bound' into cisco-whitel…

79ba68a

…ist-xcm-storage

kianenigma reviewed Jun 27, 2023

View reviewed changes

paritytech-ci requested a review from a team June 27, 2023 09:18

kianenigma approved these changes Jun 27, 2023

View reviewed changes

kianenigma reviewed Jun 27, 2023

View reviewed changes

Merge remote-tracking branch 'origin/cisco-polkadot-xcm-weight-info-b…

091bf08

…ound' into cisco-whitelist-xcm-storage

franciscoaguirre merged commit e804144 into cisco-polkadot-xcm-weight-info-bound Jul 2, 2023

franciscoaguirre deleted the cisco-whitelist-xcm-storage branch July 2, 2023 20:55

franciscoaguirre mentioned this pull request Aug 15, 2023

Whitelist XCM Storage Read Each block from Benchmarking #5203

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Whitelist from benchmarking XCM storage keys read each block #6871

Whitelist from benchmarking XCM storage keys read each block #6871

franciscoaguirre commented Mar 13, 2023

ggwpez commented Mar 13, 2023

ggwpez commented Mar 13, 2023

ggwpez commented Mar 13, 2023

ggwpez commented Mar 13, 2023

franciscoaguirre commented Mar 15, 2023

franciscoaguirre commented Mar 15, 2023

franciscoaguirre commented Apr 4, 2023

franciscoaguirre commented Apr 4, 2023

franciscoaguirre commented Apr 4, 2023

kianenigma Jun 27, 2023

kianenigma left a comment

franciscoaguirre commented Jul 2, 2023

paritytech-processbot bot commented Jul 2, 2023

Whitelist from benchmarking XCM storage keys read each block #6871

Whitelist from benchmarking XCM storage keys read each block #6871

Conversation

franciscoaguirre commented Mar 13, 2023

ggwpez commented Mar 13, 2023

ggwpez commented Mar 13, 2023

ggwpez commented Mar 13, 2023

ggwpez commented Mar 13, 2023

franciscoaguirre commented Mar 15, 2023

franciscoaguirre commented Mar 15, 2023

franciscoaguirre commented Apr 4, 2023

franciscoaguirre commented Apr 4, 2023

franciscoaguirre commented Apr 4, 2023

kianenigma Jun 27, 2023

Choose a reason for hiding this comment

kianenigma left a comment

Choose a reason for hiding this comment

franciscoaguirre commented Jul 2, 2023

paritytech-processbot bot commented Jul 2, 2023