This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
fix: runtime benchmark feature #6690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muharem
added
A0-please_review
gilescope
approved these changes
Feb 8, 2023
|
is this critical to go into the current release? |
14 tasks
Probably the benchmarks won't run without this. |
|
Might work for Polkadot, but will fail for cumulus. |
|
PR to fix similar issue in cumulus paritytech/cumulus#2173 |
bkchr
approved these changes
Feb 9, 2023
ggwpez
approved these changes
Feb 9, 2023
|
@coderobe with the substrate patch paritytech/substrate#13348, I could run successfully all the benchmarks of polkadot, kusama, westend runtimes locally on the current branch. |
coderobe
approved these changes
Feb 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these changes were included into master here #6663