Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix update-node-template script #6679

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Fix update-node-template script #6679

merged 2 commits into from
Feb 8, 2023

Conversation

joao-paulo-parity
Copy link
Contributor

@joao-paulo-parity joao-paulo-parity commented Feb 7, 2023 •
edited
Loading

Fixes the problem of https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2282467

warning: Could not find remote branch polkadot-vv0.9.37 to clone.
fatal: Remote branch polkadot-vv0.9.37 not found in upstream origin

By removing the extra v within $POLKADOT_BRANCH.

Also fixes the incorrectly-hardcoded substrate because instead cumulus should be used for update-parachain-template.

@joao-paulo-parity joao-paulo-parity added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. B0-silent Changes should not be mentioned in any release notes labels Feb 7, 2023
@joao-paulo-parity joao-paulo-parity marked this pull request as ready for review February 7, 2023 10:40
@joao-paulo-parity joao-paulo-parity requested review from a team and chevdor as code owners February 7, 2023 10:40
@paritytech-ci paritytech-ci requested a review from a team February 7, 2023 10:41
@paritytech-ci paritytech-ci requested a review from a team February 7, 2023 11:27
@joao-paulo-parity
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit d008018 into paritytech:master Feb 8, 2023
@joao-paulo-parity joao-paulo-parity deleted the fix branch February 8, 2023 12:51
@kiltbot kiltbot mentioned this pull request Apr 3, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chevdor chevdor chevdor approved these changes

@EgorPopelyaev EgorPopelyaev EgorPopelyaev approved these changes

@coderobe coderobe coderobe approved these changes

@sergejparity sergejparity sergejparity approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joao-paulo-parity @chevdor @EgorPopelyaev @coderobe @sergejparity