This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add a CI check ensuring the code has license headers #6609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzadp
requested review from
mordamax,
mutantcornholio,
parutger,
Bullrich and
TriplEight
alvicsam
approved these changes
Jan 23, 2023
coderobe
approved these changes
Jan 23, 2023
mrcnski
reviewed
Jan 23, 2023
.github/workflows/check-licenses.yml
Outdated
| npx @paritytech/license-scanner@0.0.3 scan \ | ||
| --ensure-licenses Apache-2.0 \ | ||
| --ensure-licenses GPL-3.0-only \ | ||
| ./**/src/**/*.rs |
There was a problem hiding this comment.
Why not just ./**/*.rs? I think having src in there would make this not match on all files, e.g. build.rs files.
There was a problem hiding this comment.
Good call, I changed it to ./**/*.rs (and added missing licenses uncovered by it)
mrcnski
reviewed
Jan 23, 2023
the-right-joyce
added
A0-please_review
sergejparity
approved these changes
Jan 24, 2023
Bullrich
approved these changes
Jan 24, 2023
rzadp
added
B0-silent
rzadp
added
the
D3-trivial 🧸
|
bot merge |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scan looks for licenses in the source code and fails if some file does not have an Apache or GPL license header.
Scans files in the repo (so no dependencies). The scan could be extended to dependencies if needed.
Closes paritytech/license-scanner#20
Progresses paritytech/license-scanner#8