Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

update weights #5767

Merged
merged 5 commits into from
Jul 28, 2022
Merged

update weights #5767

merged 5 commits into from
Jul 28, 2022

Conversation

coderobe
Copy link
Contributor

@coderobe coderobe commented Jul 8, 2022 •
edited
Loading

🏋️‍♀️

@coderobe coderobe added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Jul 8, 2022
@github-actions github-actions bot added A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. labels Jul 8, 2022
@coderobe coderobe mentioned this pull request Jul 8, 2022
Merged
@coderobe coderobe marked this pull request as ready for review July 8, 2022 08:16
@coderobe coderobe added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Jul 8, 2022
@coderobe coderobe mentioned this pull request Jul 8, 2022
Closed
20 tasks
@coderobe
Copy link
Contributor Author

@shawntabrizi hey could you take a look at this test failure?

failures:
---- test_fees::full_block_council_election_cost stdout ----
can support 6235 voters in a single block for council elections; total bond 128291
thread 'test_fees::full_block_council_election_cost' panicked at 'assertion failed: cost_dollars > 150_000', runtime/polkadot/src/lib.rs:2128:9

@ggwpez ggwpez mentioned this pull request Jul 18, 2022
Merged
@ggwpez
Reduce testing constants (#5787)
90d97b0 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@paritytech-ci paritytech-ci requested review from a team July 18, 2022 10:39
@shawntabrizi
Copy link
Member

thanks @ggwpez

dvdplm
dvdplm approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but I have a few questions.

runtime/kusama/constants/src/weights/block_weights.rs
@@ -16,8 +16,8 @@
// limitations under the License.

//! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 4.0.0-dev
//! DATE: 2022-06-20 (Y/M/D)
//! HOSTNAME: `bm6`, CPU: `Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz`
//! DATE: 2022-07-07 (Y/M/D)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be 27th? Or do we run benchmarks before branching off the release branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an old PR that has been stuck this long. Another one should be coming up tomorrow.

runtime/polkadot/src/lib.rs Show resolved Hide resolved
@coderobe
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 63b611e into master Jul 28, 2022
@paritytech-processbot paritytech-processbot bot deleted the coderobe/weights-26 branch July 28, 2022 19:35
ordian added a commit that referenced this pull request Aug 3, 2022
@ordian
Merge branch 'master' into ao-disputes-offences-runtime
d3405cc 
* master:
  Use Saturating Math in XCM (#5845)
  Remove already executed calls to nompools MigrateToV2 migration (#5836)
  companion for #11821: node/service: add BEEFY to block import (#5796)
  Remove Unused Trait Bound (#5838)
  Companion for substrate#11523 (#5702)
  Remove Useless Inherent Data Provider (#5750)
  update weights (#5767)
  bump transcation_version for rococo (#5760) (#5830)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ggwpez ggwpez ggwpez left review comments

@dvdplm dvdplm dvdplm approved these changes

@chevdor chevdor chevdor approved these changes

@bkchr bkchr bkchr approved these changes

@EgorPopelyaev EgorPopelyaev EgorPopelyaev approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@coderobe @shawntabrizi @dvdplm @chevdor @bkchr @EgorPopelyaev @ggwpez