This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Remove Kusama Nomination Pools Init #5605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joepetrowski
added
A0-please_review
bkchr
approved these changes
May 30, 2022
|
Migrating pools to V1 is already in the 9.23 release, "making pool roles optional". |
kianenigma
approved these changes
Jun 16, 2022
|
would be nice if you clean the stale migrations from westend too. |
|
bot rebase |
|
Rebasing |
|
bot merge |
ordian
added a commit
that referenced
this pull request
Jun 17, 2022
* master: Get rid of unnecessary clone. (#5685) Remove Kusama Nomination Pools Init (#5605) Companion for paritytech/substrate#11631 (#5671) Allow relay chain council to send XCMs (#5597) Companion for substrate#11618 (#5677) Companion to combine iteratons and tolerance in sp-npos-elections API #11498 (#5581) Companion for #11661 (#5676) Bump lru from 0.7.5 to 0.7.7 (#5675) Companion PR for Substrate 11537 (#5619)
al3mart
pushed a commit
that referenced
this pull request
Jul 14, 2022
* remove kusama nomination pools init * remove OnRuntimeUpgrade import * remove stale migrations from westend Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included in the runtime v9220 release, config setup is no longer needed.
I don't think
pallet_nomination_pools::migration::v1::MigrateToV1<Runtime>is needed either but am not sure based on this thread https://github.com/paritytech/substrate/pull/11411/files#r872629403