Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

provisioner: remove utils::job usage #5568

Merged
merged 2 commits into from
May 23, 2022
Merged

provisioner: remove utils::job usage #5568

merged 2 commits into from
May 23, 2022

Conversation

slumber
Copy link
Contributor

@slumber slumber commented May 19, 2022

Part of #4259

State and requests handling is done in the main loop, inherent data construction moved to the background.

@slumber slumber changed the title Migrate provisioner subsystem provisioner: remove utils::job usage May 19, 2022
@slumber slumber added I8-refactor Code needs refactoring. A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels May 19, 2022
@slumber slumber requested review from drahnr and rphmeier and removed request for drahnr May 19, 2022 17:26
drahnr
drahnr approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@drahnr drahnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rphmeier
rphmeier approved these changes May 21, 2022
View reviewed changes
Copy link
Contributor

@rphmeier rphmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. I agree that running send_inherent_data in a background task is the most reasonable thing to do.

@rphmeier
Copy link
Contributor

bot merge

@paritytech-processbot
Copy link

Error: Statuses failed for 38127af

@rphmeier rphmeier merged commit 1a93ea9 into master May 23, 2022
@rphmeier rphmeier deleted the slumber-provisioner-remove-job branch May 23, 2022 19:43
@rphmeier
Copy link
Contributor

I merged despite the cumulus check as it's unrelated

@github-actions github-actions bot mentioned this pull request Jun 22, 2022
Closed
This was referenced Jul 18, 2022
Closed
Open
@ghbot-test ghbot-test bot mentioned this pull request Jul 28, 2022
Open
@ghzlatarev ghzlatarev mentioned this pull request Jul 29, 2022
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@drahnr drahnr drahnr approved these changes

@rphmeier rphmeier rphmeier approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. I8-refactor Code needs refactoring.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slumber @rphmeier @drahnr