Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

WIP: Westend like Polkadot should have 10 decimal places #5455

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gilescope
Copy link
Contributor

We fixed up the polkadot-js chain properties for polkadot like networks so there were no surprises when testing polkadot teleporting in this PR: #5369

We should do this for Westend also. Westend is the testbed for Polkadot and so should have 10 decimal places like Polkadot.
(Not doing this would be leaving a footgun around for someone in the future.)

@gilescope gilescope added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels May 5, 2022
@gilescope gilescope requested review from bkchr and hbulgarini May 5, 2022 08:34
@chevdor
Copy link
Contributor

chevdor commented May 5, 2022

cc @mordamax

@chevdor
Copy link
Contributor

chevdor commented May 5, 2022

It will boil down to whether Westend is a tesnet for Polkadot, Kusama or simply a chain of its own.
I would tend to the later.

This change can potentially introduce a mess for downstream projects that don't check the decimals of the network, which can be seen as a positive point :)

Also Blockchain explorers will need to redo the jazz about wnd and old_wnd and my guess is that most people would prefer to avoid that effort for a test network.

@gilescope gilescope requested a review from joepetrowski May 5, 2022 09:15
@gilescope
Copy link
Contributor Author

Hmm the x100 isn't happening doing the teleport between westmint and westend so that means that there's another additional way in which it's not like polkadot. We should not merge just this as it's necessary but not sufficient.

@gilescope gilescope changed the title Westend like Polkadot should have 10 decimal places WIP: Westend like Polkadot should have 10 decimal places May 5, 2022
@gilescope
Copy link
Contributor Author

Westend did not do the re-denomination when polkadot did. It does not make sense to do this alone.

@gilescope gilescope closed this May 5, 2022
@bkchr bkchr deleted the giles-westend-is-polkadotesk branch May 5, 2022 10:07
@chevdor chevdor mentioned this pull request Jul 6, 2022
@gilescope gilescope restored the giles-westend-is-polkadotesk branch July 21, 2022 12:52
@gilescope gilescope reopened this Jul 21, 2022
@gilescope
Copy link
Contributor Author

Joe mentioned that we should point exchanges at the re-denomination details when this change is rolled out to westend.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants