Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

sudo call to establish hrmp channel #4998

Closed
wants to merge 3 commits into from
Closed

sudo call to establish hrmp channel #4998

wants to merge 3 commits into from

Conversation

stanly-johnson
Copy link
Contributor

resolves #4648

bkchr
bkchr approved these changes Feb 27, 2022
View reviewed changes
runtime/parachains/src/hrmp.rs Outdated Show resolved Hide resolved
runtime/parachains/src/hrmp.rs Outdated Show resolved Hide resolved
@bkchr bkchr requested a review from pepyakin February 27, 2022 19:36
stanly-johnson and others added 2 commits February 28, 2022 00:03
@stanly-johnson @bkchr
Update runtime/parachains/src/hrmp.rs
9f8dcf3 
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
@stanly-johnson @bkchr
Update runtime/parachains/src/hrmp.rs
53fec01 
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
pepyakin
pepyakin approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@pepyakin pepyakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,

One thing that we could be done here or in a follow-up is to see if we can remove this function from paras_sudo_wrapper to avoid duplication.

runtime/parachains/src/hrmp.rs Show resolved Hide resolved
@joepetrowski
Copy link
Contributor

Would be nice to pass the deposits into {init, accept}_open_channel so that channels opened by Root don't need a deposit. It would remove the need to transfer from the Treasury, and makes sense given that governance is the spam-limiting means.

@gilescope gilescope added A0-please_review Pull request needs code review. B1-releasenotes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels May 17, 2022
@hbulgarini
Copy link

@stanly-johnson , do you think that you can address this comment from joe? I think this feature will very simplify the usage for opening hrmp channels.

@joepetrowski joepetrowski mentioned this pull request Oct 14, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

@gilescope gilescope gilescope left review comments

@pepyakin pepyakin pepyakin approved these changes

@shawntabrizi shawntabrizi shawntabrizi approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Root call to open / accept / establish HRMP channel
7 participants
@stanly-johnson @joepetrowski @hbulgarini @gilescope @shawntabrizi @pepyakin @bkchr