This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Co #10897: Storage benchmarking #4982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added
A4-companion
shawntabrizi
approved these changes
Feb 25, 2022
cheme
approved these changes
Feb 25, 2022
|
Waiting for commit status. |
nuke-web3
reviewed
Mar 7, 2022
| @@ -54,6 +54,9 @@ pub enum Subcommand { | |||
| #[clap(name = "benchmark", about = "Benchmark runtime pallets.")] | |||
| Benchmark(frame_benchmarking_cli::BenchmarkCmd), | |||
|
|
|||
| #[clap(name = "benchmark-storage", about = "Benchmark storage speed.")] | |||
There was a problem hiding this comment.
Disclaimer: This CAN CORRUPT YOUR DB so please make a backup before using this on a real snapshot; paritytech/substrate#10897 (comment)
@ggwpez should the command help not mention something to this effect to help end users not "footgun" on this?
There was a problem hiding this comment.
Running the command as is,will also require the --storage-version flag, so you cannot just run it accidentally.
The corruption can only occur for RocksDB, but I agree to make it a bit more explicit.
Maybe even add a --i-used-a-backup flag?
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
benchmark-storagesub-command from Storage benchmarking substrate#10897Disclaimer: This CAN CORRUPT YOUR DB so please make a backup before using this on a real snapshot; discussion