Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Revert connectivity fix 0.9.17 #4943

Merged
merged 2 commits into from
Feb 18, 2022
Merged

Revert connectivity fix 0.9.17 #4943

merged 2 commits into from
Feb 18, 2022

Conversation

eskimor
Copy link
Member

@eskimor eskimor commented Feb 18, 2022

Improve parachain block times for 0.9.17

@eskimor eskimor added A0-please_review Pull request needs code review. B1-releasenotes C1-low PR touches the given topic and has a low impact on builders. labels Feb 18, 2022
@eskimor eskimor added this to the v0.9.17 milestone Feb 18, 2022
@coderobe
Copy link
Contributor

Is/has this landed in master? If so, pls link the companion PR

@coderobe coderobe self-assigned this Feb 18, 2022
@eskimor
Copy link
Member Author

eskimor commented Feb 18, 2022

@coderobe : #4914

@coderobe
Copy link
Contributor

coderobe commented Feb 18, 2022 •
edited
Loading

Is it intentional that 9fe8132e862945fae2da8fe8813aa5511d02268d is not in this backport?

coderobe
coderobe suggested changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@coderobe coderobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commits are unsigned; Any reason not to directly cherry-pick the commits that went into master?

@eskimor
Copy link
Member Author

eskimor commented Feb 18, 2022

Is it intentional that 9fe8132e862945fae2da8fe8813aa5511d02268d is not in this backport?

Yes, that commit never landed on the release branch, so we can't revert it.

@eskimor eskimor force-pushed the rk-revert-connectivity-fix-0.9.17 branch from ee245a5 to 98ddc39 Compare February 18, 2022 12:33
@eskimor
Copy link
Member Author

eskimor commented Feb 18, 2022

Commits are unsigned; Any reason not to directly cherry-pick the commits that went into master?

Done.

@ordian ordian force-pushed the rk-revert-connectivity-fix-0.9.17 branch from 98ddc39 to b92eb63 Compare February 18, 2022 12:40
@coderobe coderobe merged commit e8017ee into release-v0.9.17 Feb 18, 2022
@coderobe coderobe deleted the rk-revert-connectivity-fix-0.9.17 branch February 18, 2022 13:31
@ordian ordian mentioned this pull request Feb 21, 2022
Closed
@ghzlatarev ghzlatarev mentioned this pull request Mar 2, 2022
Closed
This was referenced Mar 4, 2022
Closed
Closed
@Dengjianping Dengjianping mentioned this pull request Apr 19, 2022
Merged
10 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ordian ordian ordian approved these changes

@coderobe coderobe coderobe approved these changes

Assignees

@coderobe coderobe

Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
v0.9.17
Development

Successfully merging this pull request may close these issues.
3 participants
@eskimor @coderobe @ordian