Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

move to rust 2021 #4279

Closed
wants to merge 5 commits into from
Closed

move to rust 2021 #4279

wants to merge 5 commits into from

Conversation

nuke-web3
Copy link
Contributor

@nuke-web3 nuke-web3 commented Nov 14, 2021

close #4277
Confirmed to build locally on Ubuntu 20.04.3 LTS:

rustc 1.56.1 (59eed8a2a 2021-11-01)
rustc 1.58.0-nightly (e90c5fbbc 2021-11-12)

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Nov 14, 2021
@nuke-web3 nuke-web3 added B1-releasenotes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. E2-dependencies Pull requests that update a dependency file. labels Nov 14, 2021
@nuke-web3
Copy link
Contributor Author

rust-version = "1.56.1" introduced

For reference, I tried to get this to cargo build with 1.56.0 and it failed with

error: package `...` cannot be built because it requires rustc 1.56.1 or newer, while the currently active rustc version is 1.56.0

With --ignore-rust-version it does build with 1.56.0, as expected.

Copy link
Contributor

@KiChjang KiChjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it still gud

@@ -3,7 +3,8 @@ name = "millau-bridge-node"
description = "Substrate node compatible with Millau runtime"
version = "0.1.0"
authors = ["Parity Technologies <admin@parity.io>"]
edition = "2018"
edition = "2021"
rust-version = "1.56.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't touch any bridges code here. That needs to be done upstream.

@drahnr
Copy link
Contributor

drahnr commented Apr 22, 2022

Closing, migration already happened in 645ae551fcce .

@drahnr drahnr closed this Apr 22, 2022
@ordian ordian deleted the ds/2021 branch April 22, 2022 08:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. E2-dependencies Pull requests that update a dependency file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Rust 2021 edition
4 participants