This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
move to rust 2021 #4279
Closed
move to rust 2021 #4279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuke-web3
requested review from
acatangiu,
adoerr,
antonio-dropulic,
svyatonik and
tomusdrw
as code owners
November 14, 2021 01:13
nuke-web3
added
B1-releasenotes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit.
E2-dependencies
Pull requests that update a dependency file.
labels
Nov 14, 2021
KiChjang
approved these changes
Nov 14, 2021
For reference, I tried to get this to
With |
KiChjang
approved these changes
Nov 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it still gud
bkchr
suggested changes
Nov 21, 2021
@@ -3,7 +3,8 @@ name = "millau-bridge-node" | |||
description = "Substrate node compatible with Millau runtime" | |||
version = "0.1.0" | |||
authors = ["Parity Technologies <admin@parity.io>"] | |||
edition = "2018" | |||
edition = "2021" | |||
rust-version = "1.56.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't touch any bridges code here. That needs to be done upstream.
Closing, migration already happened in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit.
E2-dependencies
Pull requests that update a dependency file.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4277
Confirmed to build locally on Ubuntu 20.04.3 LTS: