This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
enable ApprovalCheckingVotingRule on Polkadot #4072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
added
A0-please_review
drahnr
approved these changes
Oct 13, 2021
…lkadot * master: use pipeline-scripts for dependent projects script (#4017) companion for substrate/10013 (#4078) fix restart issue of staking miner (#4073) use `WEIGHT_PER_SECOND` (#4077) Switch to compressed runtimes (#4061) Create a README for XCMv1 detailing notable changes (#4058) Bump proc-macro2 from 1.0.29 to 1.0.30 (#4071)
rphmeier
approved these changes
Oct 15, 2021
ordian
added a commit
that referenced
this pull request
Oct 15, 2021
* master: enable ApprovalCheckingVotingRule on Polkadot (#4072)
emostov
pushed a commit
that referenced
this pull request
Nov 1, 2021
* enable ApprovalCheckingVotingRule on Polkadot * fmt
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and on a
--devchain (checked #3358 is no longer reproducible). Now that Polkadot has properParachainHostimpl, this will integrate approval checking and disputes into grandpa finality rule as well as BABE's chain selection.Fixes #3326.