Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

v0.9.11-rc4 #4027

Merged
merged 3 commits into from
Oct 7, 2021
Merged

v0.9.11-rc4 #4027

merged 3 commits into from
Oct 7, 2021

Conversation

s3krit
Copy link
Contributor

@s3krit s3krit commented Oct 6, 2021

@s3krit s3krit added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Oct 6, 2021
.saturating_add((347_000 as Weight).saturating_mul(e as Weight))
.saturating_add((168_000 as Weight).saturating_mul(k as Weight))
// Standard Error: 4_000
.saturating_add((768_000 as Weight).saturating_mul(e as Weight))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Significant increase

fn cancel(s: u32, ) -> Weight {
(24_455_000 as Weight)
// Standard Error: 7_000
.saturating_add((1_849_000 as Weight).saturating_mul(s as Weight))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Significant decrease

fn cancel_named(s: u32, ) -> Weight {
(26_842_000 as Weight)
// Standard Error: 9_000
.saturating_add((1_880_000 as Weight).saturating_mul(s as Weight))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Significant decrease

(2_809_466_000 as Weight)
// Standard Error: 181_000
.saturating_add((16_204_000 as Weight).saturating_mul(s as Weight))
(6_584_935_000 as Weight)
Copy link
Contributor

@chevdor chevdor Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Significant 📈

@shawntabrizi
Copy link
Member

/benchmark runtime kusama pallet_scheduler

@parity-benchapp
Copy link

parity-benchapp bot commented Oct 6, 2021

Error running benchmark: mp-v0.9.11-weights

stdoutFrom https://github.com/paritytech/polkadot * branch master -> FETCH_HEAD f520483..a14bdf1 master -> origin/master

// Storage: Vesting Vesting (r:1 w:1)
// Storage: Balances Locks (r:1 w:1)
fn vest_locked(l: u32, s: u32, ) -> Weight {
(45_931_000 as Weight)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

significant 📉

// Storage: Vesting Vesting (r:1 w:1)
// Storage: Balances Locks (r:1 w:1)
fn vest_unlocked(l: u32, s: u32, ) -> Weight {
(45_326_000 as Weight)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

significant 📉

// Storage: Balances Locks (r:1 w:1)
// Storage: System Account (r:1 w:1)
fn vest_other_unlocked(l: u32, s: u32, ) -> Weight {
(45_906_000 as Weight)
Copy link
Contributor

@chevdor chevdor Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

significant 📉 + others around the vestedcalls

fn register() -> Weight {
(4_193_117_000 as Weight)
(8_869_444_000 as Weight)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

significant 📈 (+1 below)

fn force_lease() -> Weight {
(92_502_000 as Weight)
(44_857_000 as Weight)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

significant 📉

.saturating_add((328_000 as Weight).saturating_mul(e as Weight))
.saturating_add((166_000 as Weight).saturating_mul(k as Weight))
// Standard Error: 3_000
.saturating_add((722_000 as Weight).saturating_mul(e as Weight))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

significant 📈

Copy link
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spotted a few noticeable to ♾ going from 0 to a few millions.
The big changes should be checked. There are especially quick some in the vesting pallet

// Storage: Vesting Vesting (r:1 w:1)
// Storage: Balances Locks (r:1 w:1)
fn vest_locked(l: u32, s: u32, ) -> Weight {
(45_502_000 as Weight)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

significant 📉

// Storage: Vesting Vesting (r:1 w:1)
// Storage: Balances Locks (r:1 w:1)
fn vest_unlocked(l: u32, s: u32, ) -> Weight {
(45_054_000 as Weight)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

significant 📉

// Storage: Balances Locks (r:1 w:1)
// Storage: System Account (r:1 w:1)
fn vest_other_locked(l: u32, s: u32, ) -> Weight {
(45_957_000 as Weight)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

significant 📉 on vest*

fn force_lease() -> Weight {
(92_502_000 as Weight)
(41_290_000 as Weight)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

significant 📉

fn batch(c: u32, ) -> Weight {
(20_055_000 as Weight)
// Standard Error: 3_000
.saturating_add((7_234_000 as Weight).saturating_mul(c as Weight))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

significant 📈

fn batch_all(c: u32, ) -> Weight {
(22_129_000 as Weight)
// Standard Error: 3_000
.saturating_add((7_909_000 as Weight).saturating_mul(c as Weight))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

significant 📈

// Storage: Vesting Vesting (r:1 w:1)
// Storage: Balances Locks (r:1 w:1)
fn vest_locked(l: u32, s: u32, ) -> Weight {
(45_631_000 as Weight)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

significant 📉

// Storage: Vesting Vesting (r:1 w:1)
// Storage: Balances Locks (r:1 w:1)
fn vest_unlocked(l: u32, s: u32, ) -> Weight {
(45_068_000 as Weight)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

significant 📉 again for all the vest*

.saturating_add((44_792_000 as Weight).saturating_mul(k as Weight))
// Storage: Skipped Metadata (r:0 w:0)
fn refund(k: u32, ) -> Weight {
(42_888_000 as Weight)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BIGGGGG 📈 ♾

fn register() -> Weight {
(4_178_287_000 as Weight)
.saturating_add(T::DbWeight::get().reads(5 as Weight))
(7_233_188_000 as Weight)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

significant 📈

* add slot offset for slots

* trying things out

* fix test

* improve api to return the first block of a new lease period

* add an integration test with offset

* de-duplicate test

* hide lease period_period_length from public api

* fix benchmarks

* Update runtime/common/src/slots.rs

* support the exact same range of crowdloans

* fix docs

* fix docs again

* introduce offset to runtimes

* fix and check edge case w/ offset and lease period first block

* remove newline

* turn into an option

* fix benchmarks

Co-authored-by: Robert Habermeier <rphmeier@gmail.com>
@s3krit s3krit changed the title v0.9.11 weights v0.9.11-rc4 Oct 7, 2021
@s3krit s3krit merged commit bfd38ed into release-v0.9.11 Oct 7, 2021
@s3krit s3krit deleted the mp-v0.9.11-weights branch October 7, 2021 16:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants