Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

avoid expect, on free availability core #3994

Merged
merged 6 commits into from
Oct 3, 2021
Merged

avoid expect, on free availability core #3994

merged 6 commits into from
Oct 3, 2021

Conversation

drahnr
Copy link
Contributor

@drahnr drahnr commented Oct 2, 2021

The assumption is a tad to strict.

@drahnr drahnr self-assigned this Oct 2, 2021
@drahnr drahnr added A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Oct 2, 2021
@drahnr drahnr force-pushed the bernhard-dispute-bitefield-issue branch from 44af848 to c5f7303 Compare October 2, 2021 11:49
@rphmeier
Copy link
Contributor

rphmeier commented Oct 2, 2021 •
edited
Loading

Another thing we could do is add a 'bitmask' parameter to the process_bitfields function which takes a bitfield derived from the dispute-freed cores. That seems to be a better approach than this, which allows validators to set arbitrary bits. I still like being extra-strict in the runtime.

@drahnr drahnr changed the title avoid expect, on free availaility core avoid expect, on free availability core Oct 2, 2021
@rphmeier rphmeier merged commit 8e7486b into master Oct 3, 2021
@rphmeier rphmeier deleted the bernhard-dispute-bitefield-issue branch October 3, 2021 11:09
ordian added a commit that referenced this pull request Oct 3, 2021
@ordian
Merge branch 'master' into bernhard-malus-fx
e0f8223 
* master: (72 commits)
  change genesis authority set for wococo-local, revert rococo-local (#3998)
  ignore irrelevant approvals in logs (#3859)
  avoid expect, on free availability core (#3994)
  preserve finalized block in active leaves (#3997)
  some tweaks to rococo-local (#3996)
  always broadcast tranche 0 assignments and add a delay before approval (#3904)
  Tidy up XCM errors in preparation for v2. (#3988)
  add disputes call to Rococo (#3993)
  Fix an off-by-one: revert rather than revert-to (#3991)
  add logs to relay chain selection (#3990)
  av-store: clean up StoreAvailableData message (#3984)
  add polkadot-simnet runner (#3985)
  Remove incorrect proof about Jemalloc (#3982)
  add new rococo chainspec (#3976)
  bump async-std's version to remove conflict for substrate (#3981)
  gossip-support: set last_session_index earlier (#3978)
  Companion for substrate PR#9890 (#3961)
  Bump version, tx_version and spec_version in prep for v0.9.11 (#3970)
  Fix master compilation (#3977)
  Make most XCM APIs accept an Into<MultiLocation> where MultiLocation is accepted (#3627)
  ...
ordian added a commit to Lldenaurois/polkadot that referenced this pull request Oct 3, 2021
@ordian
Merge branch 'master' into ladi-logging-disputes
2cd9542 
* master:
  Remove unoccupied bit check (paritytech#3999)
  bump substrate (paritytech#4000)
  change genesis authority set for wococo-local, revert rococo-local (paritytech#3998)
  ignore irrelevant approvals in logs (paritytech#3859)
  avoid expect, on free availability core (paritytech#3994)
ordian added a commit that referenced this pull request Oct 5, 2021
@ordian
Merge branch 'master' into andre/companion-9448
9e0e469 
* master: (138 commits)
  Allow an Offset to Lease Periods (#3980)
  Bump quote from 1.0.9 to 1.0.10 (#4013)
  Companion for #9834 (Transaction Priority) (#3901)
  chore: update `builder` image (#3884)
  Free disputed cores before processing bitfields (#4008)
  Make candidate validation timeouts configurable (#4001)
  Add extrinsic ordering filtering (#3631)
  chore: ci list files that spellcheck finds (#3992)
  Use background tasks properly in candidate-validation (#4002)
  Fix unoccupied bitfields (#4004)
  Bump syn from 1.0.77 to 1.0.78 (#4006)
  Bump jsonrpsee-ws-client from 0.3.0 to 0.3.1 (#3931)
  fix clock drift for assignments issued before the block (#3851)
  Remove unoccupied bit check (#3999)
  bump substrate (#4000)
  change genesis authority set for wococo-local, revert rococo-local (#3998)
  ignore irrelevant approvals in logs (#3859)
  avoid expect, on free availability core (#3994)
  preserve finalized block in active leaves (#3997)
  some tweaks to rococo-local (#3996)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ordian ordian ordian left review comments

@rphmeier rphmeier rphmeier approved these changes

Assignees

@drahnr drahnr

Labels
A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drahnr @rphmeier @ordian