Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove BEEFY repo dependency #3923

Merged
merged 1 commit into from
Sep 24, 2021
Merged

Remove BEEFY repo dependency #3923

merged 1 commit into from
Sep 24, 2021

Conversation

adoerr
Copy link
Contributor

@adoerr adoerr commented Sep 24, 2021

Remove dependencies on the standalone BEEFY repository and use the Substrate integrate version of BEEFY instead.

@adoerr adoerr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Sep 24, 2021
ordian
ordian approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd good to deduplicate libsecp256k1, but that might require upgrading libp2p

@adoerr
Copy link
Contributor Author

adoerr commented Sep 24, 2021

Merging Bump libsecp256k1 from 0.6.0 to 0.7.0 would accomplish this, I gues.

@ordian
Copy link
Member

ordian commented Sep 24, 2021

libp2p still on 0.5:

polkadot/Cargo.lock

Line 3389 in 8938a0d

"libsecp256k1 0.5.0",

@adoerr
Copy link
Contributor Author

adoerr commented Sep 24, 2021

Yeah, just discovered that as well 🙈

@adoerr
Copy link
Contributor Author

adoerr commented Sep 24, 2021

bot merge

@ghost
Copy link

ghost commented Sep 24, 2021

Merge aborted: Checks failed for e1fbc07

@ordian ordian merged commit bbedad9 into master Sep 24, 2021
@ordian ordian deleted the ad-beefy-deps branch September 24, 2021 15:51
ordian added a commit that referenced this pull request Sep 28, 2021
@ordian
Merge branch 'master' into temporary-malus-2
0709de3 
* master: (24 commits)
  Added multisig in Rococo (#3873)
  Fix bin-substrate toml (#3939)
  Bump tracing from 0.1.27 to 0.1.28 (#3937)
  XCM Benchmarks for Asset Transactor w/ Fungible Asset (#3818)
  Bump libc from 0.2.101 to 0.2.102 (#3933)
  Do not compile `wasm_api` module when not needed. (#3934)
  Bump syn from 1.0.76 to 1.0.77 (#3932)
  Fix spelling (#3845)
  Bump tokio from 1.11.0 to 1.12.0 (#3910)
  Ignore `generate-bags` by dependabot (#3930)
  Update logging in paras_inherent (#3927)
  Bump libsecp256k1 from 0.6.0 to 0.7.0 (#3909)
  Remove BEEFY repo dependency (#3923)
  Substrate Companion for rust 1.54 (#3807)
  Fix broken links (#3919)
  update BaseXcmWegiht to match Kusama (#3911)
  add parachains pallets to Polkadot runtime (#3815)
  Add a `force_unfreeze` extrinsic to the disputes module (#3906)
  Add new rococo chainspec (#3905)
  Ensure all parachain configuration extrinsics are operational (#3912)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adoerr @ordian