Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix flaky availability-recovery test #3812

Merged
2 commits merged into from
Sep 8, 2021
Merged

Fix flaky availability-recovery test #3812

2 commits merged into from
Sep 8, 2021

Conversation

eskimor
Copy link
Member

@eskimor eskimor commented Sep 8, 2021

Fixes #3798

@eskimor eskimor added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Sep 8, 2021
ordian
ordian approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Fixes" 😄

@eskimor
Copy link
Member Author

eskimor commented Sep 8, 2021

What's wrong with the test suite?

@ordian
Copy link
Member

ordian commented Sep 8, 2021

What's wrong with the test suite?

It's flaky as well :P The compilation process was SIGKILLed, so the usual redis cache OOM or something like that.

@ordian
Copy link
Member

ordian commented Sep 8, 2021

bot merge

@ghost
Copy link

ghost commented Sep 8, 2021

Trying merge.

@ghost ghost merged commit 04735b5 into master Sep 8, 2021
@ghost ghost deleted the rk-fix-flaky-test branch September 8, 2021 12:56
ordian added a commit that referenced this pull request Sep 9, 2021
@ordian
Merge branch 'master' into ao-optional-polkadot-runtime
d10d891 
* master:
  Bump tokio from 1.10.1 to 1.11.0 (#3821)
  Add words to the dictionnary (#3819)
  Add vault secrets to puplish-rustdoc job (#3816)
  Change pipeline to use Vault (#3722)
  Don't drop UMP queue items if weight exhausted (#3784)
  Fix flaky availability-recovery test (#3812)
  participate in disputes only if haven't voted already (#3796)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flakey Test in Availability Recovery
2 participants
@eskimor @ordian