Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Substrate Companion for #9566 #3704

Merged
13 commits merged into from
Sep 21, 2021
Merged

Substrate Companion for #9566 #3704

13 commits merged into from
Sep 21, 2021

Conversation

ferrell-code
Copy link
Contributor

@ferrell-code ferrell-code commented Aug 24, 2021 •
edited
Loading

Companion for paritytech/substrate#9566

Migration of Pallet Prefix of "Treasury" to "Bounties" for pallet_bounties

@ferrell-code ferrell-code changed the title Companion for #9566 Substrate Companion for #9566 Aug 24, 2021
@ferrell-code ferrell-code mentioned this pull request Aug 24, 2021
Merged
@gui1117 gui1117 added A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Sep 9, 2021
gui1117
gui1117 approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, I tested with try-runtime on current state kusama and polkadot

@ferrell-code
Copy link
Contributor Author

Thanks for the help @thiolliere , but take care that it works right, I don't quite fully trust myself with the storage migration 📦

@shawntabrizi
Copy link
Member

any updates on testing the migration?

@gui1117
Copy link
Contributor

gui1117 commented Sep 13, 2021

I tested with try-runtime 4 days ago, the substrate has no new change since, apart from benchmarking fix.

@ferrell-code
Copy link
Contributor Author

yeah its good on my end too, storage migrations just give me anxiety haha

@ghost
Copy link

ghost commented Sep 21, 2021

Error: Companion update failed: Command 'Command { std: "git" "push" "ferrell-code" "fer-companion-9566", kill_on_drop: false }' failed with status Some(1); output: To https://github.com/ferrell-code/polkadot.git
! [remote rejected] fer-companion-9566 -> fer-companion-9566 (refusing to allow a GitHub App to create or update workflow .github/workflows/honggfuzz.yml without workflows permission)
error: failed to push some refs to 'https://x-access-token:${SECRET}@github.com/ferrell-code/polkadot.git'

@ordian
Copy link
Member

ordian commented Sep 21, 2021

cc @joao-paulo-parity ^^^

@joao-paulo-parity
Copy link
Contributor

joao-paulo-parity commented Sep 21, 2021 •
edited
Loading

#3704 (comment) is related to paritytech/parity-processbot#302. I guess some workflow files were unintentionally brought in during merge master (07d1830) and that is why it failed.

@ordian
Copy link
Member

ordian commented Sep 21, 2021

bot merge

@ghost
Copy link

ghost commented Sep 21, 2021

Waiting for commit status.

@ghost ghost merged commit c406f7b into paritytech:master Sep 21, 2021
@ordian
Copy link
Member

ordian commented Sep 21, 2021 •
edited
Loading

Does Westend also need a migration?

EDIT: resolved.

@ferrell-code ferrell-code deleted the fer-companion-9566 branch September 21, 2021 18:21
ordian added a commit that referenced this pull request Sep 24, 2021
@ordian
Merge branch 'master' into temporary-malus
819ac1c 
* master:
  Companion for Generate storage info for pallet grandpa #9817 (#3892)
  add tracing to assignment criteria (#3886)
  Add benchmarking for parachain runtime paras pallet (#3888)
  companion for substrate#9788 (#3858)
  Substrate Companion for #9566 (#3704)
@ferrell-code ferrell-code mentioned this pull request Oct 18, 2021
Closed
5 tasks
@ferrell-code ferrell-code mentioned this pull request Nov 25, 2021
Merged
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ordian ordian ordian approved these changes

@gui1117 gui1117 gui1117 approved these changes

Assignees
No one assigned
Labels
A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ferrell-code @shawntabrizi @gui1117 @ordian @joao-paulo-parity