Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

extract determine_new_blocks into a separate utility #3261

Merged
merged 2 commits into from
Jun 16, 2021
Merged

extract determine_new_blocks into a separate utility #3261

merged 2 commits into from
Jun 16, 2021

Conversation

rphmeier
Copy link
Contributor

This is a refactoring to give other subsystems the ability to iterate back to the last known or finalized block when inspecting a new leaf.

@rphmeier rphmeier added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Jun 15, 2021
@rphmeier rphmeier mentioned this pull request Jun 15, 2021
Closed
ordian
ordian approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems straightforward.

node/subsystem-util/src/determine_new_blocks.rs Outdated Show resolved Hide resolved
@rphmeier rphmeier merged commit c3da55c into master Jun 16, 2021
@rphmeier rphmeier deleted the rh-ancestry-import-util branch June 16, 2021 19:10
ordian added a commit that referenced this pull request Jun 17, 2021
@ordian
Merge branch 'master' into ao-improved-gossip-topology
e59d267 
* master:
  Companion #9019 (max rpc payload override) (#3276)
  Implementers' Guide: Chain Selection (#3262)
  CLI: Add missing feature checking and check if someone passes a file (#3283)
  Export 'TakeRevenue' trait. (#3278)
  Add XCM Decode Limit (#3273)
  Allow Council to Use Scheduler (#3237)
  fix xcm pallet origin (#3272)
  extract determine_new_blocks into a separate utility (#3261)
  Approval checking unit tests (#3252)
  bridges: update finality-grandpa to 0.14.1 (#3266)
  malus - mockable overseer mvp (#3224)
  use safe math (#3249)
  Companion for #8920 (Control Staking) (#3260)
  Companion for #8949 (#3216)
@rphmeier rphmeier mentioned this pull request Jun 18, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rphmeier @ordian