Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update purchase pallet to FRAME v2 #3075

Merged
merged 4 commits into from
Jun 2, 2021
Merged

Update purchase pallet to FRAME v2 #3075

merged 4 commits into from
Jun 2, 2021

Conversation

shaunxw
Copy link
Contributor

@shaunxw shaunxw commented May 22, 2021 •
edited
Loading

Part of #2882

Converts the Purchase pallet to the new pallet attribute macro introduced in #6877.

Following the upgrade guidelines here: https://crates.parity.io/frame_support/attr.pallet.html#upgrade-guidelines.

⚠️ Breaking Change ⚠️

From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines

storages now use PalletInfo for module_prefix instead of the one given to decl_storage: Thus any use of this pallet in construct_runtime! should be careful to update name in order not to break storage or to upgrade storage (moreover for instantiable pallet). If pallet is published, make sure to warn about this breaking change.

So users of the Purchase pallet must be careful about the name they used in construct_runtime!. Hence the runtime-migration label, which might not be needed depending on the configuration of the Purchase pallet.

@KiChjang KiChjang mentioned this pull request May 23, 2021
Closed
9 tasks
@shaunxw shaunxw changed the title Update purchase wrapper pallet to FRAME v2 Update purchase pallet to FRAME v2 May 23, 2021
@KiChjang KiChjang added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels May 23, 2021
@shawntabrizi
Copy link
Member

This pallet is not used in any runtime, and thus no worries about any migration or breaking changes here. Thank you @shaunxw

gui1117
gui1117 approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Shawnx, the check-runtime CI is failing, but the current change doesn't affect any runtime in polkadot thus it is a false-negative

@gui1117
Copy link
Contributor

gui1117 commented Jun 2, 2021 •
edited
Loading

bot force merge
EDIT: bot seems not to respond

@shawntabrizi shawntabrizi merged commit 783a56f into paritytech:master Jun 2, 2021
@shaunxw shaunxw deleted the sw/migrate-purchase branch June 2, 2021 22:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@gui1117 gui1117 gui1117 approved these changes

@KiChjang KiChjang KiChjang approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shaunxw @shawntabrizi @gui1117 @KiChjang