Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update para sudo wrapper pallet to FRAME v2 #3074

Merged
2 commits merged into from
Jun 1, 2021
Merged

Update para sudo wrapper pallet to FRAME v2 #3074

2 commits merged into from
Jun 1, 2021

Conversation

shaunxw
Copy link
Contributor

@shaunxw shaunxw commented May 22, 2021

Part of #2882

Converts the ParaSudoWrapper pallet to the new pallet attribute macro introduced in #6877.

Following the upgrade guidelines here: https://crates.parity.io/frame_support/attr.pallet.html#upgrade-guidelines.

⚠️ Breaking Change ⚠️

From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines

storages now use PalletInfo for module_prefix instead of the one given to decl_storage: Thus any use of this pallet in construct_runtime! should be careful to update name in order not to break storage or to upgrade storage (moreover for instantiable pallet). If pallet is published, make sure to warn about this breaking change.

So users of the ParaSudoWrapper pallet must be careful about the name they used in construct_runtime!. Hence the runtime-migration label, which might not be needed depending on the configuration of the ParaSudoWrapper pallet.

@shaunxw shaunxw changed the title Migrate para sudo wrapper pallet to pallet attribute macro. Update para sudo wrapper pallet to FRAME v2 May 22, 2021
@KiChjang KiChjang mentioned this pull request May 23, 2021
Closed
9 tasks
@KiChjang KiChjang added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. B1-releasenotes B0-silent Changes should not be mentioned in any release notes and removed B1-releasenotes labels May 23, 2021
shawntabrizi
shawntabrizi approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no decl storage in this pallet

@shawntabrizi
Copy link
Member

bot merge

@ghost
Copy link

ghost commented Jun 1, 2021

Trying merge.

@ghost ghost merged commit 7f3745f into paritytech:master Jun 1, 2021
@shaunxw shaunxw deleted the sw/migrate-para-sudo-wrapper branch June 2, 2021 03:11
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KiChjang KiChjang KiChjang approved these changes

@shawntabrizi shawntabrizi shawntabrizi approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaunxw @shawntabrizi @KiChjang